Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nix): add scarb package manager to development tools #453

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented Jan 6, 2025

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Build-related changes

What is the current behavior?

Currently, the nix development environment doesn't include Scarb, which is necessary for e2e tests.

Resolves: #NA

What is the new behavior?

  • Adds Scarb package manager (v2.8.2) to the development environment
  • Includes all necessary Scarb binaries
  • Supports multiple platforms
  • Properly integrates with the existing Nix development shell

Does this introduce a breaking change?

No

Other information

@jbcaron jbcaron self-assigned this Jan 6, 2025
@Trantorian1 Trantorian1 added the infrastructure CI/CD, deployment and infrastructure changes label Jan 6, 2025
tools/scarb.nix Outdated
homepage = "https://github.com/software-mansion/scarb";
license = licenses.mit;
platforms = builtins.attrNames systemMap;
maintainers = [];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

tools/scarb.nix Outdated Show resolved Hide resolved
tools/scarb.nix Outdated Show resolved Hide resolved
tools/scarb.nix Show resolved Hide resolved
@jbcaron jbcaron force-pushed the chore/add-scarb-nix branch from 689f2c9 to d914fc2 Compare January 6, 2025 18:17
@jbcaron jbcaron requested a review from Trantorian1 January 6, 2025 20:48
Copy link
Collaborator

@Trantorian1 Trantorian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider formatting this with alejandra

@antiyro antiyro merged commit b542867 into main Jan 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure CI/CD, deployment and infrastructure changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants