fix(devnet): loosened devnet chain id restrictions #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trantorian1
added
bug
Trantorian1
requested review from
cchudant,
antiyro,
apoorvsadana and
jbcaron
apoorvsadana
approved these changes
Dec 30, 2024
Trantorian1
force-pushed
the
fix/devnet
branch
from
8778b26 to
dd549d5
Compare
heemankv
approved these changes
Jan 7, 2025
notlesh
reviewed
Jan 7, 2025
There was a problem hiding this comment.
This seems fine to me, but I'm wondering why this is a big deal.
If I spin up a dev chain and use some private keys, I should know not to reuse private keys that I'm using on some other chain, and this should be sufficient to prevent any replay attacks of any value, right? Is there more to it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
Current restrictions around devnet chain id to avoid replay attacks do not make entire sense and are a bit too strict.
Resolves: #302
What is the new behavior?
Devnet chain id restrictions have been loosed to only forbid devnets with
STARKNET_MAINNETorSTARKNET_SEPOLIAchain ids. An additinal warning has been added to theREADMEto warn agains such potential replay attacksDoes this introduce a breaking change?
No