Feat: Replace Class Hash issue resolved, gas fees bug resolved, cap removed for pending tick #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 3, 2024 17:35
added 2 commits
December 9, 2024 17:10
Trantorian1
requested changes
Dec 10, 2024
Trantorian1
requested changes
Dec 10, 2024
jbcaron
reviewed
Dec 18, 2024
jbcaron
reviewed
Dec 18, 2024
antiyro
reviewed
Dec 18, 2024
| @@ -77,6 +77,15 @@ pub enum Error { | |||
| #[error("State diff error when continuing the pending block: {0:#}")] | |||
| PendingStateDiff(#[from] StateDiffToStateMapError), | |||
| } | |||
|
|
|||
| struct ContinueBlockResult { | |||
There was a problem hiding this comment.
could you document this struct for rust doc?
cchudant
requested changes
Dec 23, 2024
| @@ -353,8 +351,13 @@ impl<Mempool: MempoolProvider> BlockProductionTask<Mempool> { | |||
|
|
|||
There was a problem hiding this comment.
i think you should split the on_block_time function in two: on_block_time and close_block and on_pending_block_tick should call close_block instead of on_block_time
There was a problem hiding this comment.
did something very similar, lmk wdyt?
cchudant
requested changes
Dec 23, 2024
| interval_pending_block_update.reset_at(instant + interval_pending_block_update.period()); | ||
| interval_block_time.reset_at(instant + interval_block_time.period()); | ||
| } | ||
| self.current_pending_tick += 1; |
There was a problem hiding this comment.
could you reset the current_pending_tick to 0 as well?
(i believe the current pending tick variable is now useless, is that the case?
There was a problem hiding this comment.
yeah I thought about it as well, pushing the changes that I think made sense, lmk wdyt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
No