Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jd-gui: update to 1.6.6 #6073

Merged
merged 2 commits into from
Jan 8, 2020
Merged

jd-gui: update to 1.6.6 #6073

merged 2 commits into from
Jan 8, 2020

Conversation

lhaeger
Copy link
Contributor

@lhaeger lhaeger commented Dec 30, 2019

Tested on

macOS 10.15.2 19C57
Xcode 11.3 11C29

Verification

Have you

  • followed our Commit Message Guidelines?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@pmetzger
Copy link
Member

pmetzger commented Jan 2, 2020

@lhaeger This seems okay to me but I really don't feel qualified to evaluate the Java changes. Have you submitted those upstream, btw?

@lhaeger
Copy link
Contributor Author

lhaeger commented Jan 3, 2020

@pmetzger Yes, I've send a pull request for patch to enable native macOS file dialogs in parallel to the jd-gui project (--> java-decompiler/jd-gui#283) but did not want to wait for approval since it's pretty concise and straight forward and just seems to work.
I could remove the default_variants statement and make it an optional choice until upstream includes the patch, if you think that's a safer choice.

@pmetzger
Copy link
Member

pmetzger commented Jan 8, 2020

I don't really have an opinion on whether it's a better choice or not. What we need is someone better qualified to evaluate this PR.

@lhaeger
Copy link
Contributor Author

lhaeger commented Jan 8, 2020

I don't really have an opinion on whether it's a better choice or not. What we need is someone better qualified to evaluate this PR.

I've removed the default_variants statement and added "experimental" to the variant description, so nobody should get the patch by default and those who choose to use it should understand that it's at their own risk.
If/when upstream merges their pull request this will tickle down into the non-variant code anyway and until then it's an easy way to try it out (which might help getting the upstream PR validated and accepted).

@mf2k mf2k merged commit 80fdc46 into macports:master Jan 8, 2020
@lhaeger lhaeger deleted the jd-gui branch January 8, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants