Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlto: Fix build in trace mode #26780

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

neverpanic
Copy link
Member

Description

xsltproc, docbook-xml and docbook-xsl-nons are not just required at runtime (depends_run), but also at build time (i.e., they must be in depends_build).

Since xmlto does not care what architecture the xsltproc binary is and does not link against libxslt.dylib, add it to depends_skip_archcheck.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.1.1 24B91 arm64
Xcode 16.1 16B40

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

xsltproc, docbook-xml and docbook-xsl-nons are not just required at
runtime (depends_run), but also at build time (i.e., they must be in
depends_build).

Since xmlto does not care what architecture the xsltproc binary is and
does not link against libxslt.dylib, add it to `depends_skip_archcheck`.
@macportsbot macportsbot added type: bugfix maintainer: none by: member Created by a member with commit rights labels Nov 27, 2024
@neverpanic neverpanic merged commit e714f2e into macports:master Nov 27, 2024
3 checks passed
@neverpanic neverpanic deleted the cal-xmlto-tracemode branch November 27, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: none type: bugfix
Development

Successfully merging this pull request may close these issues.

2 participants