Remove usage of deprecated VOID macro
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only argue a bit with the commit message; not everything here is about VOID from what I can see in the actual changes. I'd change it to "Remove VOID and fix unnecessary casts". |
chrstphrchvz
force-pushed
the
no-VOID
branch
from
78d210f
to
9a182d8
Compare
|
Is the commit message okay now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VOIDmacro (from tcl.h) was for compatibility with systems lackingvoid(where it would instead be defined tochar). It is to be deprecated in Tcl 8.7 and removed in Tcl 9.0. Usage ofVOID *in Tcl, such as for the.internalRep.otherValuePtrfield of aTcl_Obj, has been replaced withvoid *; casts are no longer needed when assigning to/from.internalRep.otherValuePtr.