Adding bootrom support #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyhu
requested changes
Dec 2, 2018
jeremyhu
reviewed
Dec 2, 2018
| @@ -50,7 +50,7 @@ | |||
| #include <xhyve/virtio.h> | |||
| #include <xhyve/block_if.h> | |||
|
|
|||
| #define VTBLK_RINGSZ 64 | |||
| #define VTBLK_RINGSZ 128 | |||
There was a problem hiding this comment.
This should be broken out into a separate commit with additional justification.
jeremyhu
reviewed
Dec 2, 2018
| goto done; | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
NIT: I'd put this comment up by the definition of MAX_BOOTROM_SIZE
jeremyhu
reviewed
Dec 2, 2018
| goto done; | ||
| } | ||
|
|
||
| if (fstat(fd, &sbuf) < 0) { |
jeremyhu
reviewed
Dec 3, 2018
| @@ -2041,6 +2042,7 @@ vmx_exit_process(struct vmx *vmx, int vcpu, struct vm_exit *vmexit) | |||
| */ | |||
| gpa = vmcs_gpa(vcpu); | |||
| if (vm_mem_allocated(vmx->vm, gpa) || | |||
| bootrom_contains_gpa(gpa) || | |||
There was a problem hiding this comment.
I cannot articulate why, exactly, but I'm concerned with this particular change. It feels like a layering violation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.