Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always blocklist xpc_dictionary_set_mach_send, add macOS build matrix for CI #23

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Always blocklist xpc_dictionary_set_mach_send, add macOS build matrix for CI #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a9ce15
add macOS CI matrix
timsutton Apr 11, 2024
534c1ad
blocklist xpc_dictionary_set_mach_send
timsutton Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,32 @@ env:

jobs:
build:

runs-on: macos-latest
strategy:
fail-fast: false
matrix:
include:
- runner: macos-12
xcode_version: 14.0.1 # macOS SDK: 12.3
- runner: macos-12
xcode_version: 14.2 # macOS SDK: 13.1
- runner: macos-13
xcode_version: 15.2 # macOS SDK: 14.2
- runner: macos-14
xcode_version: 15.3 # macOS SDK: 14.4
# optionally opt into latest stable Xcode version in future
# - runner: macos-14
# xcode_version: latest-stable
runs-on: ${{ matrix.runner }}

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Setup Xcode version
uses: maxim-lobanov/[email protected]
with:
xcode-version: ${{ matrix.xcode_version }}
- name: Build
run: cargo build --verbose
run: |
echo "macOS SDK version: $(xcrun --sdk macosx --show-sdk-version)"
cargo build --verbose
- name: Run tests
run: cargo test --verbose
2 changes: 2 additions & 0 deletions xpc-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ fn main() {
.allowlist_function("^xpc_.*")
.allowlist_var("^_xpc_.*")
.allowlist_var("^bootstrap_port")
// This function began appearing as of macOS 14.4 SDK headers
.blocklist_function("xpc_dictionary_set_mach_send")
// The following symbols should probably be in libc or mach2, but are not
.allowlist_function("^mach_port.*")
.allowlist_function("^vm_allocate")
Expand Down