Retry PR #131
Merged
Retry PR #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added additional descriptions.
for more information, see https://pre-commit.ci
Added additional descriptions.
for more information, see https://pre-commit.ci
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@IamShubhamGupto - could you please help us merging this? |
|
@dhruvbalwada Unfortunately, this pr is emerging from another fork so for me to look into the changes, I have to fork the existing fork. I could hop on a call and see the changes from your side to understand the problem better |
dhruvbalwada
approved these changes
Aug 4, 2023
|
Thanks Shubham, I merged it now. I noticed now that the changes were only to files that i have not recently touched. That was my main concern, that it may over write something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to pull the new commits from main before the PR. It seems a bit messy. Let me know if there is any problem.