-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Weblate into monerujo + remove fuzzy translations #966
Closed
Closed
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
4f5a569
Remove tools:ignore flags
lucasmz-dev c7641e2
Disable linting for MissingTranslation
lucasmz-dev c9416b5
Remove translation of strings that were changed
lucasmz-dev 232408b
Remove english duplicates from translations
lucasmz-dev a414a19
Update credits in translation files
lucasmz-dev b447784
Translated using Weblate (Portuguese (Brazil))
lucasmz-dev b1d2f5d
Translated using Weblate (Portuguese (Brazil))
lucasmz-dev 46eebad
Point README translation to Weblate
lucasmz-dev feb0788
Update translation files
weblate c1421e2
Translated using Weblate (Spanish)
m2049r 08db669
Merge branch 'master' of https://github.com/m2049r/xmrwallet into web…
lucasmz-dev a7eaed6
Translated using Weblate (Spanish)
gallegonovato fcba819
Translated using Weblate (Portuguese (Brazil))
lucasmz-dev 1b70dee
Add language view + typo fix to README
lucasmz-dev 7761299
Make "Scan" translatable
lucasmz-dev 4e7f058
Translated using Weblate (Spanish)
gallegonovato 4bb4813
Translated using Weblate (Spanish)
gallegonovato 845f415
Translated using Weblate (Portuguese (Brazil))
lucasmz-dev b0df4af
Translated using Weblate (Spanish)
gallegonovato 34d776f
Translated using Weblate (Portuguese (Brazil))
lucasmz-dev 03ef5e3
Translated using Weblate (Spanish)
gallegonovato c13506d
Remove some extra leftover english duplicates
lucasmz-dev 06fb102
Handle "Changed to" strings
lucasmz-dev e2ba12b
Fix random broken translation
lucasmz-dev f3df34d
Fix translation inconscienties found manually in PT-BR that are prese…
lucasmz-dev a29e7dd
Translated using Weblate (Portuguese (Brazil))
lucasmz-dev b746ec6
Turkish + French translations manual import
lucasmz-dev bffb95d
Update swedish translation
lucasmz-dev bbf587f
Translated using Weblate (Spanish)
gallegonovato ac94fa9
Set untranslatable strings as so
lucasmz-dev b478beb
Translated using Weblate (Portuguese (Brazil))
lucasmz-dev 99de9c2
Merge branch 'master' into weblate
lucasmz-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i still don't think we should be losing good translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean I can just go over and just cherry-pick the barebones, but the reason why I went over with this is that we can't for sure know for every language that they are in fact "good translations"
Changing wording can mean very different things in different languages and affect what gender's used, word position, stuff like that, that's the reason I went over like this, the people who want to make these translations work out will and with Weblate any changes in the future can be easily fixed by translators and not go unnoticed
If you're fine with that, I'll do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weblate has a pretty nice graceful way to deal with "fuzzy" translations, they're marked as needing for editing and show the differences done in the source string, but it doesn't do anything about old commits before integration with it, that's basically what I tried to achieve here, in the end it'd be less work in the end to you and the translators IMO
A lot of translators aren't gonna have the energy/time/want to go through everything, and just wanna be able to translate right off the bat, I am like that for certain apps, especially when they have a messy situation anyway
RN my suggestion is: check #975 and I'll rebase this and then you can see if you want this, so that we can get weblate hosting at least since we'll need those to get things working at a basic level