Special testing process for LVDS TTL #2532
Conversation
| default_ttl_out_name, _ = self.ttl_lvds[ttl_out_index] | ||
|
|
||
| print("LVDS TTL channels are tested in groups of 4.") | ||
| print("You can choose any channel within the group.") |
There was a problem hiding this comment.
Would it be better to specify the group (channel % 4), or have it "align" to a group?
There was a problem hiding this comment.
It already does it (?) - if you specify any channel in group ttl0...ttl3, it will select that group.
There was a problem hiding this comment.
As in, instead of asking for a channel, it would ask for a group (instead of ttl3, group 0). Especially here, where a unit of test is essentially a group anyway - you connect the RJ45 cable to one. Then you wouldn't have to calculate the lower boundary either.
It is a bit of a nitpick and functionally wouldn't change anything, but I would consider it being a bit confusing at a first glance.
There was a problem hiding this comment.
I thought about it, but decided that it would confuse the tester more.
artiq/frontend/artiq_ddb_template.py
Outdated
| @@ -140,18 +140,21 @@ def process_dio(self, rtio_offset, peripheral, num_channels=8): | |||
| class_names[peripheral["bank_direction_high"]] | |||
| ] | |||
| channel = count(0) | |||
| board = peripheral["board"].lower() if "board" in peripheral else "" | |||
|
|
||
| print(f"*** Testing LVDS TTL") | ||
|
|
||
| if len(self.ttl_lvds_ins) == 0: |
There was a problem hiding this comment.
if not self.ttl_lvds_ins:
Signed-off-by: Egor Savkin <[email protected]>
Signed-off-by: Egor Savkin <[email protected]>
Signed-off-by: Egor Savkin <[email protected]>
Signed-off-by: Egor Savkin <[email protected]>
If output channel is last, then there is one ports movement less Signed-off-by: Egor Savkin <[email protected]>
thomasfire
force-pushed
the
2287-lvds-test
branch
from
758c0ed
to
6365287
Compare
ARTIQ Pull Request
Description of Changes
Implements special testing process for LVDS TTL - needs it being set so that it has at least one group of inputs and outputs each.
Related Issue
Closes #2287
Type of Changes
Steps
All Pull Requests
Code Changes