Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default widget image alt to null #638

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Default widget image alt to null #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
207ddb1
default widget image alt to null
inghamemerson Jun 19, 2024
96c556a
merge in upstream
ashyablok Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dist/pathfora.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2747,6 +2747,7 @@
var widgetImage = document$1.createElement('img');
widgetImage.src = config.image;
widgetImage.className = 'pf-widget-img';
widgetImage.alt = '';
if (config.layout === 'button') ; else if (config.layout === 'modal' || config.layout === 'inline') {
widgetContent.appendChild(widgetImage);
} else {
Expand Down
2 changes: 1 addition & 1 deletion dist/pathfora.min.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/rollup/widgets/construct-widget-layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ export default function constructWidgetLayout(widget, config) {
var widgetImage = document.createElement('img');
widgetImage.src = config.image;
widgetImage.className = 'pf-widget-img';
widgetImage.alt = '';
if (config.layout === 'button') {
// NOTE Images are not compatible with the button layout
} else if (config.layout === 'modal' || config.layout === 'inline') {
Expand Down