Fix browser-cookies error in clientOnly mode #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betoharres
force-pushed
the
fix-initialCred
branch
from
6ebf63d to
e16cbab
Compare
After getting the initialCredentials, the lib was trying to persist data using undefined variables and returning a undefined user. Also, the variables `firstTimeLogin` and `mustResetPassword` were never set in the clientOnly mode, so the actionsCreator related to them was never being fired due the conditional statement requiring these variables to be set. The parseResponse method was refactored to allow a optional callback in order to be reused in the applyConfig method as well.
betoharres
force-pushed
the
fix-initialCred
branch
from
e16cbab to
8d24d55
Compare
|
Thanks @betoharres - I'll review this today 👍 |
|
Thanks a bunch! I was starting in React/ES6 world when I wrote that commit |
|
Any update on this? |
|
I don't think so. Are you still facing the same probelms? |
|
@betoharres Yeah :( |
|
@jclif could you create a test repo so I can clone to see what can I do? |
betoharres
force-pushed
the
fix-initialCred
branch
from
c93b312 to
8d24d55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #77 without tests
It fix
clientOnlymode parsing undefined variables and fix modals not showing becauseof undefined variables
Check bed6b3b commit message for more info