RFC: modify guardian_lose_with_guards win condition in guardian #463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent guardian game [~2010-12-20 23:00 UTC] had this rather surprising interaction:
The day started with 3 wolves alive, 2 GA, and 1 vil alive.
wolf gunner shoots and wounds one of GA, and gets lynched afterward.
On their lynch, guardian_lose_with_guards gets triggered.
Triggering wolf win condition on wolf lynch seems counterintuitive, so this patch seeks to alleviate that [lpl does not include absent players during the day, so that's why I chose this approach].
An alternate fix would be switching
lwolves == lguardians
tolwolves >= lguardians
so wolves would get their win when GA was shot, not sure what was an intention here.