Add skip_missing flag, add Input enum (closes #26) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawroman
force-pushed
the
better-handle-files
branch
from
0b8b089 to
3ac68b8
Compare
|
Draft looks good to me. 👍 |
Closed
pawroman
commented
Dec 1, 2020
pawroman
commented
Dec 1, 2020
|
@mre It took way longer than I thought, but it should be OK to go now |
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
| } | ||
| } | ||
|
|
||
| impl<P: AsRef<Path>> From<P> for FileType { |
There was a problem hiding this comment.
Very nice use of AsRef and Default above.
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
reviewed
Dec 1, 2020
mre
approved these changes
Dec 1, 2020
|
Very good PR! Thanks for tackling this @pawroman. I really like how you improved code quality across the board and paid attention to the smallest details like fixing comments and making the code more idiomatic. Thanks for that. |
pawroman
force-pushed
the
better-handle-files
branch
from
34b68af to
3b0d811
Compare
Also add max_concurrency to collect_links
pawroman
commented
Dec 2, 2020
pawroman
commented
Dec 2, 2020
|
So happy to merge this. A major step forward and built with great attention to detail. Looking forward to whatever you'll tackle next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle input arguments in a more structured way, with the ability to skip missing files.
Done:
collect_linksmethod for faster operation with multiple inputs/files