-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
275 improve roadmap #276
275 improve roadmap #276
Conversation
I wouldn't do that, I chose the smaller color pallet, since it will also be displayed on fullscreen tty |
Alright, i think i know what the problem is. I'll install TTY and work on that |
…o use a blinker and not a thread
@JanekKermit Hey, so I did some formatting, added the periodic event manager to the roadmap and changed the blink animation to not use a thread. Also I would suggest deriving But so far I really like the new roadmap. |
Hi, thanks for reformating. I tried using se.Test, but i couldn't make it work, if i remember correctly, there was some weird issues with engine interpreting station width incorrectly and destroying the roadmap window. Anyway, I will try to implement it via se.Text again and report if I encounter any errors. When it comes to colors I wanted to use broad color palette, that's why i used raw escape codes, but if you like |
Hmm, maybe you where setting the colors directly in the text rather than using the |
@JanekKermit I refactored the code a bit to make it mergable and changed the Station inheritance |
Thanks again for reformating and sorry for so many mistakes. Only thing I would like to point out is that you deleted |
Nor problem, I really liked, what you did and wanted it merged. And yes that was intentional, i thought it would then be clearer, where the map is. |
#275 Changelog:
/pokete_classes/roadmap.py
/pokete_data/mapstations.py
/pokete_data/mapstations.py
/pokete_classes/color.py
to use 256 color palette (old system caused weird colors in some terminals, like one built-in VS Code)Preview: