Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish formats #195

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Publish formats #195

wants to merge 29 commits into from

Conversation

MaFeLP
Copy link
Collaborator

@MaFeLP MaFeLP commented Jun 19, 2022 •
edited
Loading

This pull request adds many publishing formats. Including:

  • as a flatpak (published on Flathub)
  • as a snap (published on the snapstore)
  • as a docker image (published on ghcr and Docker Hub via CI/CD (needs Added dockerfile and updated README #135 to be merged first)
  • As a .deb (downloadable from the releases page, built with CI/CD)
  • As a .rpm (downloadable from the releases page, built with CI/CD)
  • Add a windows .msi installer (publish it on winget and the releases page with CI/CD)
  • Add a macOS .app (downloadable from the releases page)
  • Include the PKGBULID for ArchLinux users in this repository

Features for pokete include:

  • An update checker
  • Which packaging format the currently installed instance of pokete uses (git as default, or one of the above)
  • Cleaned up assets directory
  • an SVG of the Pokete logo (currently only needs some clean up)

MaFeLP added 4 commits June 19, 2022 14:30
@MaFeLP
Startet adding a flatpak manifest
dd5e0f9 
Current bugs:

- No Icon is displayed in the .desktop entry
- The App does not launch from the .desktop entry

Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Removed unneeded old "assets"
c068571 
Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Added an icon of pokete as SVG
291f056 
Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Added flatpak build script
787abc3 
WARNING:
The icon in the .desktop file currently does NOT work!
The 0.8.0 release is required to add the .svg file to the release files!

Signed-off-by: MaFeLP <[email protected]>
@MaFeLP MaFeLP added the enhancement New feature or request label Jun 19, 2022
@MaFeLP MaFeLP self-assigned this Jun 19, 2022
@lxgr-linux
Copy link
Owner

Include the PKGBULID for ArchLinux users in this repository

I think I would have to move the git repository in?

@MaFeLP
Copy link
Collaborator Author

MaFeLP commented Jun 19, 2022

Include the PKGBULID for ArchLinux users in this repository

I think I would have to move the git repository in?

Do you mean as a submodule? For this, we would have to either contact the current owner or just include the git version...

@magnus-ISU
Copy link
Contributor

As an arch user, I don't think the PKGBUILD really needs to be included. I've seen projects that do, but you can't store that PKGBUILD on the AUR anyway, and since it's already on the AUR I don't see the point in us trying to maintain it here as well.

@MaFeLP
Copy link
Collaborator Author

MaFeLP commented Jun 19, 2022

As an arch user, I don't think the PKGBUILD really needs to be included. I've seen projects that do, but you can't store that PKGBUILD on the AUR anyway, and since it's already on the AUR I don't see the point in us trying to maintain it here as well.

It would then be the same with the flatpak build script.

I think adding the git repository of the AUR package/flathub package will show that these projects are 'officially' packaged versions of Pokete.

@lxgr-linux
Copy link
Owner

But just the git version if "official".

@MaFeLP MaFeLP mentioned this pull request Jun 19, 2022
Closed
7 tasks
@MaFeLP MaFeLP force-pushed the publish-formats branch from e1ab431 to b0a40a6 Compare June 20, 2022 20:04
@MaFeLP MaFeLP force-pushed the publish-formats branch from b0a40a6 to 1123ade Compare June 20, 2022 20:43
MaFeLP and others added 4 commits June 22, 2022 21:10
@MaFeLP
Further update the appstream file
8142c33 
Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Made import calls local
49b862f 
Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Added pip setup file and pyproject.toml
6ac623f 
Important: the setup.py must be executed to prepare the directories for
use with pip.

Signed-off-by: MaFeLP <[email protected]>
@MaFeLP @MartinTerp @anothervictimofsurvivalinstinct
Added Dockerfile
1ec9c5b 
Added the dockerfile from pull request #135, as there seems to be no
more work being done on it.

Currently sound does not work with docker.

Co-authored-by: MartinTerp <[email protected]>
Co-authored-by: Victim <94010769+anothervictimofsurvivalinstinct@users.noreply.github.com>
@MaFeLP MaFeLP mentioned this pull request Jul 21, 2022
Closed
@lxgr-linux
Copy link
Owner

look, a gentoo package https://packages.gentoo.org/packages/games-rpg/pokete

MaFeLP and others added 13 commits August 5, 2022 16:46
@MaFeLP
Switched all release imports to from release import ...
3c20206 
Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Merge branch 'master' into publish-formats
acc6866
@MaFeLP
Removed unnecessary file.
508d89f 
The flatpak builder manifest can be found here:
https://github.com/flathub/com.github.lxgr_linux.pokete/

Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Updated the setup.py to install playsound as well.
ba6c29e 
Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Added a debian build script.
f2bfbc5 
Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Added implementation for new playsound to the setup process.
f6d288a 
Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Added automatic builds of the debian package to the release workflow
5cd860f 
Signed-off-by: MaFeLP <[email protected]>
@lxgr-linux
Made debbuild executable
004ca9c
@lxgr-linux
Added curl as a dependancy
0b7949e
@lxgr-linux
Updated version in release.py
524607c
@MaFeLP
Updated the dockerfile to work with the new playsound system
c2c2548 
Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Added a snap package
2db190d 
Signed-off-by: MaFeLP <[email protected]>
@MaFeLP
Updated the snap base to core22
84b4a6e 
Signed-off-by: MaFeLP <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MaFeLP MaFeLP

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaFeLP @lxgr-linux @magnus-ISU