Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network_integration: add network_integration resource #173

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

network_integration: add network_integration resource #173

wants to merge 3 commits into from

Conversation

jonatas-lima
Copy link

Closes #122

@stgraber
Copy link
Member

Hi @jonatas-lima, we typically split those kind of PRs into three commits:

  • docs
  • config
  • tests

Any chance you can edit your PR to split your change into those three chunks?

https://github.com/lxc/terraform-provider-incus/pull/155/commits for an example of the usual structure.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new network_integration resource
2 participants
@jonatas-lima @stgraber