exec: Consume websocket pings for stderr #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
changed the title
|
@stefanor could you update the commit message to include the |
stgraber
reviewed
Nov 15, 2024
|
Very nice catch. I had started to look into this a few weeks ago, but the time needed to reproduce and debug was a bit annoying :) |
@cjwatson pointed me in the right direction, because he'd debugged something similar before. Once I knew what to look for, it was obvious what was missing. |
Fixes: lxc#1289 Signed-off-by: Stefano Rivera <[email protected]>
stefanor
force-pushed
the
stderr-websocket-pings
branch
from
afca45e
to
d098f46
Compare
|
Thanks! |
|
Would you mind cherry-picking this into the stable-6.0 branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1289