Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to Ansible Collection #7

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

mkbrechtel
Copy link
Contributor

@mkbrechtel mkbrechtel commented May 18, 2024

Refactoring of the repo to an Ansible Collection.

We now have three roles that basically do the same that the old playbooks did.

The ansible collection is now on top level of the repo.

Also i provided a playbook to recreates the terraform test environment for fast development iteration.

Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
Copy link
Contributor Author

mkbrechtel commented May 18, 2024

I will first proceed on putting the 3 playbooks for ceph, ovn and incus into 3 roles named the same. We might split that up later, but i first want to do the refactoring without changing the original logic.

@mkbrechtel mkbrechtel changed the title WIP: move terraform files to test folder WIP: Refactoring to Ansible Collection May 18, 2024
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
…ng the deploy playbook right after the recreation playbook

Signed-off-by: Markus Katharina Brechtel <[email protected]>
Signed-off-by: Markus Katharina Brechtel <[email protected]>
@mkbrechtel
Copy link
Contributor Author

mkbrechtel commented May 19, 2024

Ok, this seems to have done it. The setup now runs on my server and from what i can tell everything works.

I think we still need to do some restructuring, but this brings everything in collection form and preserves the original logic.

This is a good point to merge now so we can iterate upon this.

@mkbrechtel mkbrechtel marked this pull request as ready for review May 19, 2024 14:05
@mkbrechtel mkbrechtel changed the title WIP: Refactoring to Ansible Collection Refactoring to Ansible Collection May 19, 2024
@stgraber
Copy link
Member

Hey, just to let you know that I'm not ignoring this :)

I've looked through it a couple of times so far and got a bit overwhelmed by it and have been crazy busy with other work so haven't had the time to start picking things up from this and merging, sorry!

@mkbrechtel
Copy link
Contributor Author

mkbrechtel commented Jul 17, 2024

Hey, just to let you know that I'm not ignoring this :)

I've looked through it a couple of times so far and got a bit overwhelmed by it and have been crazy busy with other work so haven't had the time to start picking things up from this and merging, sorry!

Thank you! :)

I reviewed your latest changes, i am trying on getting the refactoring-branch to include all those.

@mkbrechtel
Copy link
Contributor Author

Hi @stgraber, i would suggest us having a little chat and make up a plan how we proceed. This is a big change and since the work is ongoing in the repo it would be complex to track all the changes, since the new structure is very much different from the old one. :)

@stgraber
Copy link
Member

@mkbrechtel sure, we can arrange a quick chat. You can use https://calendar.app.google/5FghtnkVaYiLn8JK6 to book 30min with me when you have some time.

Keep in mind that I'm quite a noob when it comes to Ansible and effectively never played with collections, so I don't have much in the way of opinion on the matter other than obviously wanting to keep the current capability of this repository to just set some variables in an inventory, run a playbook and get the whole thing developed.

If we can keep things working that way and make it easier for folks to import that logic, or part of it into their own Ansible environment, that'd be great!

@mttjohnson
Copy link

I don't know if it would be possible for me to also attend any discussion on this, but I am also interested in helping here.

If not, it would be very helpful to know what ended up being discussed and any decisions that were determined to get a better sense of the direction and plan for incorporating changes into the repo.

@stgraber
Copy link
Member

@mttjohnson we'll definitely want to update the PR/issue with whatever we come up with, but I can also let you know here about the time we end up picking and see if you happen to be available.

Given @mkbrechtel is based in Germany, I suspect it'll end up being a morning thing for us on the other side of the pond :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants