Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Apple Silicon #771

Closed
wants to merge 3 commits into from
+12,298 −1,455
Closed

Add support for Apple Silicon #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5610e5e
chore: appcenter
ayroblu Jan 10, 2021
0e53f3c
fix: rename for migration of AppCenter up a major version
ayroblu Jan 10, 2021
8c12177
chore: update sparkle
ayroblu Jan 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ platform :osx, '10.12'
target 'alt-tab-macos' do
use_frameworks!
pod 'LetsMove', :git => 'https://github.com/lwouis/LetsMove.git', :commit => '7abf4daed1a25218f2b52f2dfd190aee5a50071c'
pod 'Sparkle', :podspec => 'https://raw.githubusercontent.com/lwouis/Sparkle/master/Sparkle.podspec'
pod 'Sparkle', '1.24.0'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I was pointing to a fork of Sparkle, is because in that fork, I addressed an issue that Sparkle has, that impacts release notes in AltTab. See the 3 commits I added in that fork. Moving back to upstream may create a regression here

Copy link
Owner

@lwouis lwouis Jan 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I checked Sparkle 1.24.0 release notes, and they have merged my fix (I had shared a PR with them back then). The issue is that since then I've updated my fix further. I should share my improvements in a PR, and re-fork Sparkle in the meanwhile.

pod 'ShortcutRecorder', :git => 'https://github.com/Kentzo/ShortcutRecorder.git', :commit => 'f718220854575bad86fa89dd2bb3decd0b14b2b0'
pod 'SwiftyMarkdown', '1.1.0'
pod 'AppCenter/Crashes', '3.3.1'
pod 'AppCenter/Crashes', '4.1.0'
end
19 changes: 9 additions & 10 deletions Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
PODS:
- AppCenter/Core (3.3.1)
- AppCenter/Crashes (3.3.1):
- AppCenter/Core (4.1.0)
- AppCenter/Crashes (4.1.0):
- AppCenter/Core
- LetsMove (1.24)
- ShortcutRecorder (3.1)
- Sparkle (1.23.1)
- Sparkle (1.24.0)
- SwiftyMarkdown (1.1.0)

DEPENDENCIES:
- AppCenter/Crashes (= 3.3.1)
- AppCenter/Crashes (= 4.1.0)
- LetsMove (from `https://github.com/lwouis/LetsMove.git`, commit `7abf4daed1a25218f2b52f2dfd190aee5a50071c`)
- ShortcutRecorder (from `https://github.com/Kentzo/ShortcutRecorder.git`, commit `f718220854575bad86fa89dd2bb3decd0b14b2b0`)
- Sparkle (from `https://raw.githubusercontent.com/lwouis/Sparkle/master/Sparkle.podspec`)
- Sparkle (= 1.24.0)
- SwiftyMarkdown (= 1.1.0)

SPEC REPOS:
trunk:
- AppCenter
- Sparkle
- SwiftyMarkdown

EXTERNAL SOURCES:
Expand All @@ -26,8 +27,6 @@ EXTERNAL SOURCES:
ShortcutRecorder:
:commit: f718220854575bad86fa89dd2bb3decd0b14b2b0
:git: https://github.com/Kentzo/ShortcutRecorder.git
Sparkle:
:podspec: https://raw.githubusercontent.com/lwouis/Sparkle/master/Sparkle.podspec

CHECKOUT OPTIONS:
LetsMove:
Expand All @@ -38,12 +37,12 @@ CHECKOUT OPTIONS:
:git: https://github.com/Kentzo/ShortcutRecorder.git

SPEC CHECKSUMS:
AppCenter: 76ecf7e959a68e36b0fd314e8dc5897660214423
AppCenter: 8832b158d17e54845c3b88a91076218f0b07174d
LetsMove: fefe56bc7bc7fb7d37049e28a14f297961229fc5
ShortcutRecorder: fdf620aca34101b0cba3b10fca815e0459254189
Sparkle: ea073ba9c69cee3ebaab8685ba1e732e14d249f7
Sparkle: 270cd27377bf04e9c128af06e3a22d0f572d6ee3
SwiftyMarkdown: 033abc9dad9a37903f81aec5188cade436f40520

PODFILE CHECKSUM: 78df0a34910c4c031a65ac3b58dc004c21b552d0
PODFILE CHECKSUM: f7be5f3250126444c8ff49c41543c32894eae84c

COCOAPODS: 1.9.1
99 changes: 99 additions & 0 deletions Pods/AppCenter/AppCenter-SDK-Apple/AppCenter.xcframework/Info.plist
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added ...K-Apple/AppCenter.xcframework/ios-arm64_arm64e_armv7_armv7s/AppCenter.framework/AppCenter
View file
Open in desktop
Binary file not shown.
42 changes: 42 additions & 0 deletions ...pCenter.xcframework/ios-arm64_arm64e_armv7_armv7s/AppCenter.framework/Headers/AppCenter.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions ...mework/Versions/A/Headers/MSAbstractLog.h → ...enter.framework/Headers/MSACAbstractLog.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading