-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native support apple silicon #1239
Conversation
Co-authored-by: Martin Wilhelmi <[email protected]> Co-authored-by: Louis Pontoise <[email protected]>
@lwouis thanks for your work! But we got the same issue, something is still wrong in the xcodeproj settings: +file /Users/travis/build/[secure]/alt-tab-macos/DerivedData/Build/Products/Debug/AltTab.app/Contents/MacOS/AltTab
3209/Users/travis/build/[secure]/alt-tab-macos/DerivedData/Build/Products/Debug/AltTab.app/Contents/MacOS/AltTab: Mach-O 64-bit executable x86_64
3210 So still no arm binary is included, I will have a look later on with my PR and see how I can fix this. |
@mnin I think the issue was that the PR builds are DEBUG. I just switched PR builds to RELEASE like release builds. On RELEASE, it should build both archs. It used to be forced to the active arch only because of this conf var: 5389bcc#L17, but I removed it in this PR Now the default is active arch in debug and all archs in release. That's what I see locally at least, and what I read from Apple's docs. |
watching now the second build ;-) |
728bd25
to
6352964
Compare
@lwouis nice! +file /Users/travis/build/[secure]/alt-tab-macos/DerivedData/Build/Products/Release/AltTab.app/Contents/MacOS/AltTab
3113/Users/travis/build/[secure]/alt-tab-macos/DerivedData/Build/Products/Release/AltTab.app/Contents/MacOS/AltTab: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64]
3114/Users/travis/build/[secure]/alt-tab-macos/DerivedData/Build/Products/Release/AltTab.app/Contents/MacOS/AltTab (for architecture x86_64): Mach-O 64-bit executable x86_64
3115/Users/travis/build/[secure]/alt-tab-macos/DerivedData/Build/Products/Release/AltTab.app/Contents/MacOS/AltTab (for architecture arm64): Mach-O 64-bit executable arm64
3116 |
Ok I'll merge on master to release the app then. It's always stressful to release where there is a large change and a CI change, but this seems like a good time to do it to me. Everything has been nicely tested, so hopefully it doesn't break for everyone 🤞 |
The download button in https://alt-tab-macos.netlify.app/ still points to old https://github.com/lwouis/alt-tab-macos/releases/download/v6.27.1/AltTab-6.27.1.zip . |
@gdubicki thank you very much for pointing it out. I checked the Jenkill/Netlify setup, and it's all correct. I think what happened is that Github was slow to update its internal state after the release was pushed there, and Netlify published the website before that was done, so with the previous version? I redeployed on Netlify manually, and it's up-to-date now. Thanks again for noticing and telling me! |
Culmination of #771 and #1094. Both authors were credited in the git history accordingly. I even used Github's
Co-authored-by
feature~