Skip to content

Commit

Permalink
Ros Release 2.23 (#925)
Browse files Browse the repository at this point in the history
* Update FW w/ syncing stall fix

* Update stereo with more robust frame sync

* Update FW with optional override of spec translation for stereo algorithm calculations

* Correct type

* Update SPIOut.hpp

to address error C4458: declaration of 'id' hides class member

* Expose center alignment scale factor for debug purposes

* Expose SIPP mempool configurable sizes

* Update FW

* Fixed usage of DeviceBootloader with incomplete DeviceInfo and added a convinience constructor

* Closes: #714

* Add alpha scaling option for StereoDepth

* Update FW before merge

* Update FW with RGB alignment fix

* Update FW with performance metrics when DEPTHAI_LEVEL=info is enabled; enable brightness filter for 0 intensity pixels by default

* Improve spatial calculation X and Y accuracy; fix RGB alignment when custom output depth size is specified

* [XLink] Increased max number of links from 32 to 64

* Add crash dump functionality

* Change API to return just crash dump

* Update FW with commit hash attached to crash dump

* Update FW with fix for serialization of thread name

* Add hasCrashDump API

* Update FW

* Update FW, crash dump contains device ID

* Enable MEDAIN spatial calculation method for SpatialDetectionNetwork

* Update FW

* Update docs

* FW: HW sync (trigger mode) enabled for OAK-D-LR, for cameras with matching FPS

* Change default SIPP buffer sizes

* Add 3A skipping option to reduce CPU usage

* Change API to be able to configure isp 3A FPS

* Update BoarConfig with limits

* Update script node python bindings

* Update FW: Add workaround for BNO sequence number limit of 256 (sensors sends uint8)

* FW: camera sensor improvements:
- AR0234 improved AE smoothness, increased max gain to 400x (first 25.6x analog),
- OV9782 on RGB/CAM-A socket max FPS: 120 (previously was only for OV9282), also improves image quality in very bright light,
- OV9782/9282 minimum exposure time decreased: 20us -> 10us, helps in very bright light. TODO update tuning to make use of it, currently only possible to use with manual exposure

* Update stereo_depth_video.cpp

* Enable interrupt mode: Update BMI driver with fixes from: boschsensortec/BMI270_SensorAPI#16

* Update ObjectTracker with improvements from rvc3

* Add API to set trackingPerClass in ObjectTracker node

* Update FW before merge

* Update FW with IMU fix for BNO

* Add IMU versioning; firmware versioning, firmware update status callbacks

* Update FW with fix for BMI timestamp

* Update FW: IMU support for OAK-D-SR

* Fix 'default constrictible' error on some compilers

* Update FW

* Add IMU FW update RPC

* Updated yolo description

* Update examples

* Update FW with deprecation warning for enableFirmwareUpdate

* Change imu version to imu type

* Update FW before merge

* Added C++14 requirement to examples & tests

* Tweaked crash_report example

* [FW] Added missing bindings for CameraControl and ImgFrame

* Update FW with fix for calibration load example

* fix stability_stress_test fail to link on ubuntu

- fixes #769

* fix isClosed/checkClosed threading, rpcClient exceptions

- remove thread-unsafe checkClosed()
- update isClosed() doxygen + comments
- protect DataInputQueue::maxDataSize with std::atomic
- remove unused dai::DeviceBase::rpcStream
- fixes #520

* fix var hides class member, this-> in constructors

- fix few compile warn 'ex' unreferenced local variable
- rename setBusId() param to not hide class member
- refactor XLinkConnection constructors
- partial fix #247

* fix: stdexcept header added for std::runtime_error

Signed-off-by: Onuralp SEZER <[email protected]>

* [FW] Removed UTF-8 degree sign from temperature prints. Closes: #773

* Move sipp buffer size from BoardConfig to GlobalProperties

* Update style

* Partially reverted bce1444 - only kept the C++14 specified in examples, tests already had the version specified

* [Stereo] Add option to invalidate edge pixels on disparity/depth frame

* Update FW: handle disparity flipping

* Update FW: support for stereo.setOutputSize when LEFT or RIGHT alignment is set

* Update FW: support for stereo between RGB and LEFT/RIGHT

* [FW] ImageManip CSC improvements, New boards and power cycle fix

* Update FW: support for configurable ImageManip interpolation type

* FW: fix for UART0 / '/dev/ttyS0' init failure in Script node

* Update API to use dai::Interpolation

* Update FW with latest develop fixes

* Update FW with fix for USB devices stuck after reboot

* Update shared

* Release v2.21.0

* Fix device destructor

* Update FW: fix spatial location calculator for 400p/480p resolution

* Release v2.21.1

* FW: Fix camera intrinsics when RGB alignment is used

* Release v2.21.2

* FW: fix running 4 cameras with Ethernet,
4th cam enabled didn't stream due to device memory allocation

* prevent duplicate xlink stream names

- fixes #469
- add test case

* [FW] Fix for OAK-D-SR camera enumeration

* [FW] OAK-D-LR R1 preparation

* [FW / BL] Updated both FW & BL for OAK-D-LR R1. ETH fixes and moved to BNO086 IMU.

* [BL] Updated to 0.0.25 release

* Deprecated misleading board socket aliases

* [FW] Match shared

* Tweaked naming a bit more

* WIP: Refactoring constructors

* Added 2 additional board socket enums

* Removed ;

* Updated FW and fixed Device constructors

* Added more checks when parsing message and a test

* Add get/set to all config messages

* Refactored logging to use device logger and capability to modify log levels for a specific device

* Added custom spdlog logger library usage and exposed profiling data globally and per device

* Updated XLink with new functionality and increased PoE search time

* Added means of grabbing global profiling data as well

* Updated XLink with 255.255.255.255 discovery added

* Applied formatting

* [Stereo] Fix auto distortion correction for 400p

* [Stereo] Fix temporal filter crash on startup

* Add missing info log level

* Logging: fixed `DEPTHAI_DEBUG=1` causing a crash at init,
`__gnu_cxx::recursive_init_error` exception due to `logger::get_level()` call

* CrashDump: add optional clear of crash dump, enabled by default

* Color/Mono/Camera: add `setRawOutputPacked` config
-- cherry-picked, FW and shared updated in upcoming commit

* ImgFrame: handle RAW10/12/14 (unpacked) like RAW16

* ToF node with ToFConfig
-- cherry-picked and squashed

* `make clangformat`

* FW: UVC: H.264 with `ImgFrame::Type::BITSTREAM`, few more config checks

* Device: fix some constructors to forward pipeline DeviceConfig

* Modified XLink to a temporary branch

* Updated XLink with fixed winusb mxid retrieval

* FW: Stereo: handle queue blocking settings

* [FW] Updated for some devices and ToF

* Added filter by device name

* [FW] WIP for S2 PoE boards

* [FW] WIP for new SoMs

* Fixed build

* [FW] Fixed camera orientation

* Add example for read calibration in script node

* Bump version to v2.22.0

* Add to cmake and fix errors

* FW: update IMX296 tuning

* [FW] Fixed OAK-D-SR and OV9782 issues

* Change printf to node.info in script node read calibration example

* ToF: Add median filter support

* Update FW to latest develop

* FW: Stereo: Apply alpha scaling parameter to RGB intrinsics when RGB alignment is enabled

* FW: fix CAM_D enumeration on OAK-FFC-4P R7

* Camera: move alpha parameter as optional to be consistent with stereo

* Update FW

* BMI: Fix accumulating latency due to slow xlink read

* Fix constructors overriding maxUsbSpeed

* hasAutofocus fix based on device name/lensPosition

* WIP: Device name improvements

* Added improvements to device naming

* Fixed device related logging

* Moved ts, tsDevice, and sequenceNum from descendants to RawBuffer

* Added getters and setters

* z_map for tof

* ts to tsDevice fix

* Updated ColorCamera's setSensorCrop comment for documentation

* Removed redundant getters and setters

* FW: add support for OAK-D-SR-PoE R1M1E1

* Fixed mistake in ImgFrame

* Ran ClangFormat

* Added DEPTHAI_ENABLE_LIBUSB option, to enable/disable USB protocol in build time

* Applied style

* Updated XLink library with some fixes

* FW: fix default fsync on OAK-D-SR-PoE. GPIO46 input by default

* hasautofocusIC

* FW: fix 4 cams crash on PoE due to memory allocation

* Update FW / shared

* FW: fix OAK-D-SR camera enum. IMX296 updates:
- support for RPi GS Cam paired with Luxonis SL6996 RPi camera adapter
- support for external trigger on XTR/XTRIG pin: active low, pulse width determines exposure time. Limitation:
needs an initial trigger shortly after start to avoid a crash, or `DEPTHAI_WATCHDOG=0` can be a workaround

* Attempt to fix serialization error on windows compiler

* Update FW

* Implemented timesync optimization

* Fixed new timesync bugs

* Moved treceive back to XLink

* Changes according to PR issue

* Clangformat

* Bump FW

* WIP: Device name improvements

* Added improvements to device naming

* FIXME: does not work on rpi

* Updated FW with changes

* Bump shared

* Fixed compiler error

* Changed struct timespec to custom struct to fix RPI size issues

* Bump shared

* FW, ColorCamera: add new almost-full-FOV resolutions for IMX378/477, scaled:
1352x1012, 4lane-only, 1/3 scaling
2024x1520, 1/2 binning

* Fixed incorrect warp in issue #882

* [FW] OAK-D SR PoE and ToF improvements

* [FW] Improved OV9782 fps handling

* Updated FW & XLink with backward compatible timestamping

* FW: fixes for AR0234 fsync, AR0234 AE max exposure: 16->33 ms,
more robust camera handling (especially in sync modes)

* fixed the order of translation multiplication

* clang update

* [FW] deviceName fixes and updated for EepromData changes

* Increased num XLink connections to 64

* Bumped num XLink connections to 64

* Update README.md

* Update changelog and package xml

* removed merge dubpicate

---------

Signed-off-by: Onuralp SEZER <[email protected]>
Co-authored-by: SzabolcsGergely <[email protected]>
Co-authored-by: anonymous-1000 <[email protected]>
Co-authored-by: TheMarpe <[email protected]>
Co-authored-by: TheMarpe <[email protected]>
Co-authored-by: alex-luxonis <[email protected]>
Co-authored-by: Erol444 <[email protected]>
Co-authored-by: szabi-luxonis <[email protected]>
Co-authored-by: Dale Phurrough <[email protected]>
Co-authored-by: Onuralp SEZER <[email protected]>
Co-authored-by: Florin Buica <[email protected]>
Co-authored-by: alex-luxonis <[email protected]>
Co-authored-by: Andrej Susnik <[email protected]>
Co-authored-by: Aniel Alexa <[email protected]>
Co-authored-by: AnielAlexa <[email protected]>
Co-authored-by: asahtik <[email protected]>
  • Loading branch information
16 people authored Nov 15, 2023
1 parent 22db649 commit 4919947
Show file tree
Hide file tree
Showing 58 changed files with 735 additions and 464 deletions.
23 changes: 23 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,29 @@
Changelog for package depthai
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

2.23.0 (2023-11-14)
-----------
* ImageManip - configurable interpolation type
* Script - added missing bindings for reading device releated data (on device calibration, etc...)
* Added Device::getDeviceName and Device::getProductName that target a user name and a "SKU" name
* Timesync - improved synchronization with tweaks to XLink
* Calibration - added housingExtrinsics
* Fix CAM_D enumeration on OAK-FFC-4P R7
* BMI270 IMU - fix latency when slow reading
* Device related logging
* OAK-D-SR-POE - new revision bugfixes
* Fix 4 cameras crash on PoE due to memory allocation
* Fixed incorrect warp in issue #882
* XLink - updated number of devices to 64
* ToF - median filter and Z map support (still not the final decoding pipeline)
* hasAutofocus value fixed and introduced hasAutofocusIC
* Added timestamps and sequence numbers to all Message types
* Added DEPTHAI_ENABLE_LIBUSB for potentially disabling USB protocol (to not require libusb library)
* OV9782 and AR0234 improvements:
* OV9782 FPS improvements
* AR0234 max exposure time bump to 33ms and improved FSync INPUT mode
* Contributors: Alex Bougdan, Szabolcs Gergely, Martin Peterlin

2.22.0 (2023-06-15)
-----------
* UVC Node - Capability to create a pipeline that sends data over UVC (or flash it)
Expand Down
16 changes: 12 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ endif()

set(HUNTER_SKIP_PACKAGE_nlohmann_json OFF)
set(BUILD_SHARED_LIBS ON)
# Early options
option(DEPTHAI_ENABLE_LIBUSB "Enable usage of libusb and interaction with USB devices" ON)

# Set type to canonicalize relative paths for user-provided toolchain
set(CMAKE_TOOLCHAIN_FILE "" CACHE FILEPATH "CMake toolchain path")

Expand Down Expand Up @@ -45,7 +48,7 @@ if(WIN32)
endif()

# Create depthai project
project(depthai VERSION "2.22.0" LANGUAGES CXX C)
project(depthai VERSION "2.23.0" LANGUAGES CXX C)
get_directory_property(has_parent PARENT_DIRECTORY)
if(has_parent)
set(DEPTHAI_VERSION ${PROJECT_VERSION} PARENT_SCOPE)
Expand Down Expand Up @@ -254,6 +257,7 @@ add_library(${TARGET_CORE_NAME}
src/utility/Environment.cpp
src/utility/XLinkGlobalProfilingLogger.cpp
src/utility/Logging.cpp
src/utility/EepromDataParser.cpp
src/xlink/XLinkConnection.cpp
src/xlink/XLinkStream.cpp
src/openvino/OpenVINO.cpp
Expand Down Expand Up @@ -449,13 +453,16 @@ target_link_libraries(${TARGET_CORE_NAME}
set(DEPTHAI_DEVICE_VERSION "${DEPTHAI_DEVICE_SIDE_COMMIT}")
target_compile_definitions(${TARGET_CORE_NAME}
PRIVATE
# XLink required define
__PC__
# Add depthai-device version
DEPTHAI_DEVICE_VERSION="${DEPTHAI_DEVICE_VERSION}"
# Add depthai-bootloader version
DEPTHAI_BOOTLOADER_VERSION="${DEPTHAI_BOOTLOADER_VERSION}"
)
# Add compile flag if libusb is available
if(DEPTHAI_ENABLE_LIBUSB)
target_compile_definitions(${TARGET_CORE_NAME} PRIVATE DEPTHAI_ENABLE_LIBUSB)
set(DEPTHAI_HAVE_LIBUSB_SUPPORT ON)
endif()

# Add Backward dependency if enabled (On by default)
if(DEPTHAI_ENABLE_BACKWARD)
Expand Down Expand Up @@ -484,8 +491,9 @@ macro(add_runtime_dependencies depending_target dependency)
set(required_dll_files ${dlls} ${depthai_dll_libraries})
# Copy the required dlls
add_custom_command(TARGET ${depending_target} POST_BUILD COMMAND
${CMAKE_COMMAND} -E copy_if_different ${required_dll_files} $<TARGET_FILE_DIR:${depending_target}>
"$<$<BOOL:${required_dll_files}>:${CMAKE_COMMAND};-E;copy_if_different;${required_dll_files};$<TARGET_FILE_DIR:${depending_target}>>"
COMMAND_EXPAND_LISTS
VERBATIM
)
message(STATUS "Required dlls for core are: ${required_dll_files}")
endif()
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# DepthAI C++ Library

[![Forum](https://img.shields.io/badge/Forum-discuss-orange)](https://discuss.luxonis.com/)
[![Docs](https://img.shields.io/badge/Docs-DepthAI_API-yellow)](https://docs.luxonis.com/projects/api)
[![License: MIT](https://img.shields.io/badge/License-MIT-green.svg)](https://opensource.org/licenses/MIT)

Core C++ library
Expand Down
2 changes: 1 addition & 1 deletion cmake/Depthai/DepthaiDeviceSideConfig.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set(DEPTHAI_DEVICE_SIDE_MATURITY "snapshot")

# "full commit hash of device side binary"
set(DEPTHAI_DEVICE_SIDE_COMMIT "f033fd9c7eb0b3578d12f90302e87759c78cfb36")
set(DEPTHAI_DEVICE_SIDE_COMMIT "39a9d271a9ed0172f6481877723fca96d41b54c6")

# "version if applicable"
set(DEPTHAI_DEVICE_SIDE_VERSION "")
6 changes: 4 additions & 2 deletions cmake/Hunter/config.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@ hunter_config(
hunter_config(
XLink
VERSION "luxonis-2021.4.2-develop"
URL "https://github.com/luxonis/XLink/archive/457b23fb33e1146610e1a4e52defa7565046977a.tar.gz"
SHA1 "006a2bd391498aea7895e988b787a420e7f51fa9"
URL "https://github.com/luxonis/XLink/archive/c940feaf9321f06a7d9660f28e686a9718135f38.tar.gz"
SHA1 "52935b6ceb470ee632de3348b9d2aaa2c6c24ac0"
CMAKE_ARGS
XLINK_ENABLE_LIBUSB=${DEPTHAI_ENABLE_LIBUSB}
)

hunter_config(
Expand Down
23 changes: 23 additions & 0 deletions cmake/config.hpp.in
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,32 @@
// This build supports OpenCV integration?
#cmakedefine DEPTHAI_HAVE_OPENCV_SUPPORT

// This build supports libusb?
#cmakedefine DEPTHAI_HAVE_LIBUSB_SUPPORT

// Build specific settings overwrite
#ifdef DEPTHAI_TARGET_CORE
#ifndef DEPTHAI_TARGET_OPENCV
#undef DEPTHAI_HAVE_OPENCV_SUPPORT
#endif
#endif

namespace dai
{
namespace build
{

#ifdef DEPTHAI_HAVE_OPENCV_SUPPORT
constexpr static bool HAVE_OPENCV_SUPPORT = true;
#else
constexpr static bool HAVE_OPENCV_SUPPORT = false;
#endif

#ifdef DEPTHAI_HAVE_LIBUSB_SUPPORT
constexpr static bool HAVE_LIBUSB_SUPPORT = true;
#else
constexpr static bool HAVE_LIBUSB_SUPPORT = false;
#endif

} // namespace build
} // namespace dai
4 changes: 3 additions & 1 deletion examples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,9 @@ function(dai_add_example example_name example_src enable_test)
set(depthai_dll_libraries "$<TARGET_RUNTIME_DLLS:${example_name}>")
endif()
add_custom_command(TARGET ${example_name} POST_BUILD COMMAND
${CMAKE_COMMAND} -E copy_if_different ${depthai_dll_libraries} $<TARGET_FILE_DIR:${example_name}>
"$<$<BOOL:${depthai_dll_libraries}>:${CMAKE_COMMAND};-E;copy_if_different;${depthai_dll_libraries};$<TARGET_FILE_DIR:${example_name}>>"
COMMAND_EXPAND_LISTS
VERBATIM
)
endif()
endfunction()
Expand Down Expand Up @@ -320,6 +321,7 @@ dai_add_example(script_json_communication Script/script_json_communication.cpp O
dai_add_example(script_change_pipeline_flow Script/script_change_pipeline_flow.cpp OFF)
target_compile_definitions(script_change_pipeline_flow PRIVATE BLOB_PATH="${mobilenet_5shaves_blob}")
dai_add_example(script_get_device_info Script/script_get_device_info.cpp ON)
dai_add_example(script_read_calibration Script/script_read_calibration.cpp ON)

# SpatialDetection
dai_add_example(spatial_location_calculator SpatialDetection/spatial_location_calculator.cpp ON)
Expand Down
2 changes: 1 addition & 1 deletion examples/ColorCamera/rgb_preview.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ int main() {
}

// Device name
cout << "Device name: " << device.getDeviceName() << endl;
cout << "Device name: " << device.getDeviceName() << " Product name: " << device.getProductName() << endl;

// Output queue will be used to get the rgb frames from the output defined above
auto qRgb = device.getOutputQueue("rgb", 4, false);
Expand Down
43 changes: 43 additions & 0 deletions examples/Script/script_read_calibration.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
#include <iostream>

// Includes common necessary includes for development using depthai library
#include "depthai/depthai.hpp"

int main() {
using namespace std;

// Start defining a pipeline
dai::Pipeline pipeline;

// Script node
auto script = pipeline.create<dai::node::Script>();
script->setProcessor(dai::ProcessorType::LEON_CSS);
script->setScript(R"(
import time
cal = Device.readCalibration2()
left_camera_id = cal.getStereoLeftCameraId()
right_camera_id = cal.getStereoRightCameraId()
extrinsics = cal.getCameraExtrinsics(left_camera_id, right_camera_id)
intrinsics_left = cal.getCameraIntrinsics(left_camera_id)
node.info(extrinsics.__str__())
node.info(intrinsics_left.__str__())
time.sleep(1)
node.io['end'].send(Buffer(32))
)");

auto xout = pipeline.create<dai::node::XLinkOut>();
xout->setStreamName("end");

script->outputs["end"].link(xout->input);

// Connect to device with pipeline
dai::Device device(pipeline);

device.getOutputQueue("end")->get();

return 0;
}
4 changes: 2 additions & 2 deletions examples/Warp/warp_mesh.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ int main() {
constexpr std::tuple<int, int> WARP1_OUTPUT_FRAME_SIZE = {992, 500};
warp1->setOutputSize(WARP1_OUTPUT_FRAME_SIZE);
warp1->setMaxOutputFrameSize(std::get<0>(WARP1_OUTPUT_FRAME_SIZE) * std::get<1>(WARP1_OUTPUT_FRAME_SIZE) * 3);
warp1->setInterpolation(dai::node::Warp::Properties::Interpolation::BYPASS);
warp1->setInterpolation(dai::Interpolation::NEAREST_NEIGHBOR);
warp1->setHwIds({1});

camRgb->preview.link(warp1->inputImage);
Expand All @@ -47,7 +47,7 @@ int main() {
// clang-format on
warp2->setWarpMesh(mesh2, 3, 3);
warp2->setMaxOutputFrameSize(maxFrameSize);
warp2->setInterpolation(dai::node::Warp::Properties::Interpolation::BICUBIC);
warp2->setInterpolation(dai::Interpolation::BICUBIC);
warp2->setHwIds({2});

camRgb->preview.link(warp2->inputImage);
Expand Down
1 change: 1 addition & 0 deletions include/depthai/common/CameraFeatures.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ inline std::ostream& operator<<(std::ostream& out, const dai::CameraFeatures& ca
}
out << "], ";
out << "hasAutofocus: " << camera.hasAutofocus << ", ";
out << "hasAutofocusIC: " << camera.hasAutofocusIC << ", ";
out << "name: " << camera.name << "}";

return out;
Expand Down
31 changes: 31 additions & 0 deletions include/depthai/device/CalibrationHandler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,37 @@ class CalibrationHandler {
uint32_t boardOptions,
std::string boardCustom = "");

/**
* Set the Board Info object. Creates version 7 EEPROM data
*
* @param deviceName Sets device name.
* @param productName Sets product name (alias).
* @param boardName Sets board name.
* @param boardRev Sets board revision id.
* @param boardConf Sets board configuration id.
* @param hardwareConf Sets hardware configuration id.
* @param batchName Sets batch name. Not supported anymore
* @param batchTime Sets batch time (unix timestamp).
* @param boardCustom Sets a custom board (Default empty string).
*/
void setBoardInfo(std::string deviceName,
std::string productName,
std::string boardName,
std::string boardRev,
std::string boardConf,
std::string hardwareConf,
std::string batchName,
uint64_t batchTime,
uint32_t boardOptions,
std::string boardCustom = "");

/**
* Set the deviceName which responses to getDeviceName of Device
*
* @param deviceName Sets device name.
*/
void setDeviceName(std::string deviceName);

/**
* Set the productName which acts as alisas for users to identify the device
*
Expand Down
15 changes: 9 additions & 6 deletions include/depthai/device/DeviceBase.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,8 @@ class DeviceBase {

/**
* Connects to device 'devInfo' with custom config.
* @param devInfo DeviceInfo which specifies which device to connect to
* @param config Device custom configuration to boot with
* @param devInfo DeviceInfo which specifies which device to connect to
*/
DeviceBase(Config config, const DeviceInfo& devInfo);

Expand Down Expand Up @@ -364,8 +364,8 @@ class DeviceBase {

/**
* Connects to device specified by devInfo.
* @param version OpenVINO version which the device will be booted with
* @param config Config with which specifies which device to connect to
* @param config Config with which the device will be booted with
* @param devInfo DeviceInfo which specifies which device to connect to
* @param maxUsbSpeed Maximum allowed USB speed
*/
DeviceBase(Config config, const DeviceInfo& devInfo, UsbSpeed maxUsbSpeed);
Expand Down Expand Up @@ -456,6 +456,12 @@ class DeviceBase {
*/
std::string getDeviceName();

/**
* Get product name if available
* @returns product name or empty string if not available
*/
std::string getProductName();

/**
* Get MxId of device
*
Expand Down Expand Up @@ -867,7 +873,6 @@ class DeviceBase {
void init(OpenVINO::Version version);
void init(OpenVINO::Version version, const dai::Path& pathToCmd);
void init(OpenVINO::Version version, UsbSpeed maxUsbSpeed);
void init(OpenVINO::Version version, bool usb2Mode, const dai::Path& pathToMvcmd);
void init(OpenVINO::Version version, UsbSpeed maxUsbSpeed, const dai::Path& pathToMvcmd);
void init(const Pipeline& pipeline);
void init(const Pipeline& pipeline, UsbSpeed maxUsbSpeed);
Expand All @@ -876,9 +881,7 @@ class DeviceBase {
void init(const Pipeline& pipeline, const DeviceInfo& devInfo, bool usb2Mode);
void init(const Pipeline& pipeline, const DeviceInfo& devInfo, UsbSpeed maxUsbSpeed);
void init(const Pipeline& pipeline, const DeviceInfo& devInfo, const dai::Path& pathToCmd);
void init(const Pipeline& pipeline, bool usb2Mode, const dai::Path& pathToMvcmd);
void init(const Pipeline& pipeline, UsbSpeed maxUsbSpeed, const dai::Path& pathToMvcmd);
void init(Config config, bool usb2Mode, const dai::Path& pathToMvcmd);
void init(Config config, UsbSpeed maxUsbSpeed, const dai::Path& pathToMvcmd);
void init(Config config, UsbSpeed maxUsbSpeed);
void init(Config config, const dai::Path& pathToCmd);
Expand Down
16 changes: 0 additions & 16 deletions include/depthai/pipeline/datatype/AprilTags.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,6 @@ class AprilTags : public Buffer {

std::vector<AprilTag>& aprilTags;

/**
* Retrieves image timestamp related to dai::Clock::now()
*/
std::chrono::time_point<std::chrono::steady_clock, std::chrono::steady_clock::duration> getTimestamp() const;

/**
* Retrieves image timestamp directly captured from device's monotonic clock,
* not synchronized to host time. Used mostly for debugging
*/
std::chrono::time_point<std::chrono::steady_clock, std::chrono::steady_clock::duration> getTimestampDevice() const;

/**
* Retrieves image sequence number
*/
int64_t getSequenceNum() const;

/**
* Sets image timestamp related to dai::Clock::now()
*/
Expand Down
Loading

0 comments on commit 4919947

Please sign in to comment.