Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix css and svg files #23

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ilyasbilgihan
Copy link

@ilyasbilgihan ilyasbilgihan commented May 14, 2022

DESCRIPTION

  • Fix: Miss/wrong-named icons has proper names now.
  • Fix: Bulk and Twotone styles showing correctly now.
  • Known-issue: Very few of the Bold and Bulk styles have small glitches, SVGs are fine but I think, converting them to icon-font causes this problem.

USAGE

  1. Import the iconsax.css file to your project.
<link rel="stylesheet" href="path/to/iconsax-css-updated/iconsax.css">
  1. Change classes to vary your icon styles.
<span class="isax-cube-scan-3d"></span>        <!-- outline -->
<span class="isax-bold-cube-scan-3d"></span>   <!--  bold   -->
<span class="isax-broken-cube-scan-3d"></span> <!-- broken  -->
<span class="isax-2tone-cube-scan-3d">         <!-- twotone -->
  <span class="path1"></span>
  <span class="path2"></span>
</span>
<span class="isax-bulk-cube-scan-3d">          <!--  bulk   -->
  <span class="path1"></span>
  <span class="path2"></span>
  <span class="path3"></span>
  <span class="path4"></span>
  <span class="path5"></span>
</span>

Note: bulk and 2tone styles must have path$ childs. Each icon may have different count of child. You need to check them from CSS file which contains that style. iconsax-css-update/path-counts.json may help you for that problem.

RECOMMENDATION

If you use only one icon style at a time, you shouldn't store other font files due to page loading speed. And it is recomended to make them minified.

Live Presentation

Old "iconsax-css" files was problematic, some of the icons was not working and some of them was miss/wrong named.
@ilyasbilgihan
Copy link
Author

@priyashpatil
Copy link

Do we have any eta on getting merged??

@dohahelmy
Copy link

@ilyasbilgihan
"Fix: Bulk and Twotone styles showing correctly now."
Twotone styles work as CSS?

@ilyasbilgihan
Copy link
Author

@ilyasbilgihan "Fix: Bulk and Twotone styles showing correctly now." Twotone styles work as CSS?

@dohahelmy Yes, I've just added an example usage above and a live presentation link.

You can get updated font css files from Files Changed tab above. (iconsax-css-updated.zip)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants