Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computer program cleanup #647

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

Computer program cleanup #647

wants to merge 29 commits into from

Conversation

kirderf1
Copy link
Member

@kirderf1 kirderf1 commented Dec 8, 2024

No description provided.

@kirderf1 kirderf1 added the cleanup Patching up existing code label Dec 8, 2024
@@ -56,14 +56,14 @@ public ComputerBlockEntity(BlockPos pos, BlockState state)
/**
* 0 = client, 1 = server, 2 = disk burner, 3 = settings
*/
public HashSet<Integer> installedPrograms = new HashSet<>();
private final Set<Integer> installedPrograms = new HashSet<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'installedPrograms' must be private and have accessor methods.

public ComputerScreen gui;
@Nullable
public PlayerIdentifier owner;
//client side only
public int ownerId;
public Hashtable<Integer, String> latestmessage = new Hashtable<>();
public CompoundTag programData = new CompoundTag();
private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'latestmessage' must be private and have accessor methods.

public Hashtable<Integer, String> latestmessage = new Hashtable<>();
public CompoundTag programData = new CompoundTag();
private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend);
private SburbServerData sburbServerProgramData = new SburbServerData(this::markDirtyAndResend);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'programData' must be private and have accessor methods.

*/
public HashSet<Integer> installedPrograms = new HashSet<>();
public ComputerScreen gui;
private final Set<ProgramType> installedPrograms = new HashSet<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'installedPrograms' must be private and have accessor methods.

@Nullable
public PlayerIdentifier owner;
private Runnable guiCallback = null;
@Nullable
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'owner' must be private and have accessor methods.

public Hashtable<Integer, String> latestmessage = new Hashtable<>();
public CompoundTag programData = new CompoundTag();
public int programSelected = -1;
private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'programData' must be private and have accessor methods.

public CompoundTag programData = new CompoundTag();
public int programSelected = -1;
private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend);
private SburbServerData sburbServerProgramData = new SburbServerData(this::markDirtyAndResend);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'programSelected' must be private and have accessor methods.

private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend);
private SburbServerData sburbServerProgramData = new SburbServerData(this::markDirtyAndResend);
@Nullable
public ProgramType programSelected = null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheck> reported by reviewdog 🐶
Variable 'hieroglyphsStored' must be private and have accessor methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Patching up existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant