-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computer program cleanup #647
base: main
Are you sure you want to change the base?
Conversation
…ore message and button texts separately
…Data(), replacing ButtonListProgram.onButtonPressed()
…d SburbServerData
@@ -56,14 +56,14 @@ public ComputerBlockEntity(BlockPos pos, BlockState state) | |||
/** | |||
* 0 = client, 1 = server, 2 = disk burner, 3 = settings | |||
*/ | |||
public HashSet<Integer> installedPrograms = new HashSet<>(); | |||
private final Set<Integer> installedPrograms = new HashSet<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable 'installedPrograms' must be private and have accessor methods.
public ComputerScreen gui; | ||
@Nullable | ||
public PlayerIdentifier owner; | ||
//client side only | ||
public int ownerId; | ||
public Hashtable<Integer, String> latestmessage = new Hashtable<>(); | ||
public CompoundTag programData = new CompoundTag(); | ||
private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable 'latestmessage' must be private and have accessor methods.
public Hashtable<Integer, String> latestmessage = new Hashtable<>(); | ||
public CompoundTag programData = new CompoundTag(); | ||
private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend); | ||
private SburbServerData sburbServerProgramData = new SburbServerData(this::markDirtyAndResend); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable 'programData' must be private and have accessor methods.
*/ | ||
public HashSet<Integer> installedPrograms = new HashSet<>(); | ||
public ComputerScreen gui; | ||
private final Set<ProgramType> installedPrograms = new HashSet<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable 'installedPrograms' must be private and have accessor methods.
@Nullable | ||
public PlayerIdentifier owner; | ||
private Runnable guiCallback = null; | ||
@Nullable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable 'owner' must be private and have accessor methods.
public Hashtable<Integer, String> latestmessage = new Hashtable<>(); | ||
public CompoundTag programData = new CompoundTag(); | ||
public int programSelected = -1; | ||
private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable 'programData' must be private and have accessor methods.
public CompoundTag programData = new CompoundTag(); | ||
public int programSelected = -1; | ||
private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend); | ||
private SburbServerData sburbServerProgramData = new SburbServerData(this::markDirtyAndResend); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable 'programSelected' must be private and have accessor methods.
private SburbClientData sburbClientProgramData = new SburbClientData(this::markDirtyAndResend); | ||
private SburbServerData sburbServerProgramData = new SburbServerData(this::markDirtyAndResend); | ||
@Nullable | ||
public ProgramType programSelected = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable 'hieroglyphsStored' must be private and have accessor methods.
No description provided.