Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LL-332 #94

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

LL-332 #94

wants to merge 4 commits into from

Conversation

erikajledesma
Copy link
Collaborator

In this PR/ticket, Google login OAuth flow has been added along with existing GitHub login functionality. The Dockerfile in the routes directory has also been modified to start both Google and GitHub Express servers. This allows the user to be able to log in with either Google or GitHub and see their profile information displayed to them once they log in and pass the consent screen.

Subsequent # (issue): LL-332

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Before testing, ask @erikajledesma to add your gmail as a test user to Google Console API.

  1. Place .env file in /routes directory (ask @erikajledesma or @aematei for the file)
  2. Run cd src/routes to get to routes directory
  3. Run docker compose build
  4. Run docker compose up
  5. Go to PORTS > link hosted at port 3000 if using codespaces (localhost will be an IP address if running on VSCode)
  6. Log in with Google
  7. Accept the consent screen
  8. When redirected, replace https://localhost:5000 with the name of your codespace or IP address. Make sure to copy the forwarded link hosted on port 5000.
  9. Check to see if JSON file is returned with your profile information.

Checklist (when relevant):

  • My code follows the style guidelines of this project

    TypeScript
    Python
    Schema

  • I have included a reviewer on the pull request [Replace this text with the reviewer]

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • My changes generate no new warnings

  • I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes

  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@pogi7 pogi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vliu36
Copy link
Collaborator

vliu36 commented Jul 25, 2024

Works for me! But one of the gh action checks have failed @erikajledesma.

Copy link
Collaborator

@vliu36 vliu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Just need to fix merge conflicts and rerun the python workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants