Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LL-171 #71

Merged
merged 15 commits into from
Oct 28, 2023
Merged

LL-171 #71

merged 15 commits into from
Oct 28, 2023

Conversation

pogi7
Copy link
Collaborator

@pogi7 pogi7 commented Oct 24, 2023

Description

Containerizes account microservice

LL-171

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Talk with @pogi7 to get environment variables
    Local Terminal:
  1. export all of the environment variables
  2. cd into the src/account directory
  3. run npm install
  4. run npx ts-node account.ts
  5. Should see
  6. account microservice listening on port: 5000
  7. Successfully connected to MongoDB.
  8. Go to any browser (chrome, firefox, etc)
  9. Go to localhost:5000/register
  10. Should see Account registered successfully in the terminal

Docker Container:

  1. In a new terminal run docker build -t account:0.0.1 .
  2. verify that the image successfully built and shows up in Docker desktop or by running docker images
  3. Run the container with the following command docker run --rm -t -e USR=USR -e PSW=PSW -e CLUS=CLUS -e DB=DB -e COL=COL --network="host" --dns=8.8.8.8 account:0.0.1
    -e are the environment variables from before
  4. Should see
  5. account microservice listening on port: 5000
  6. Successfully connected to MongoDB.
  7. Go to any browser (chrome, firefox, etc)
  8. Go to `localhost:5000/register
  9. Should see Account registered successfully in the terminal

Checklist (when relevant):

  • My code follows the style guidelines of this project

    TypeScript
    Python
    Schema

  • I have included a reviewer on the pull request @erikajledesma

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • My changes generate no new warnings

  • I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes

  • Any dependent changes have been merged and published in downstream modules

@pogi7 pogi7 added the account Account Management Feature label Oct 24, 2023
@pogi7 pogi7 requested a review from erikajledesma October 24, 2023 03:09
@pogi7 pogi7 requested a review from KevinLemon112 October 24, 2023 04:20
@pogi7 pogi7 requested a review from 1510749 October 28, 2023 04:40
Copy link
Collaborator

@1510749 1510749 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okidoki

@pogi7 pogi7 merged commit 552c05b into master Oct 28, 2023
4 checks passed
@pogi7 pogi7 deleted the LL-171 branch October 28, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account Account Management Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants