Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overview Page on Mobile #1167

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Overview Page on Mobile #1167

merged 2 commits into from
Nov 20, 2024

Conversation

mustafademiray
Copy link
Collaborator

before:
image

image

after:
image

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Deployed with Cloudflare Pages ☁️ 🚀 🆗

JeneaVranceanu
JeneaVranceanu requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@JeneaVranceanu JeneaVranceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with the number 2. It's squashed.

Screenshot 2024-11-18 at 17 26 56

CJ42
CJ42 approved these changes Nov 20, 2024
View reviewed changes
docs/learn/getting-started.md Show resolved Hide resolved
src/components/CardWithImage/index.tsx
<Card
sx={{
width: {
xs: '100%', // full width on mobile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's super clean! 🫡

@CJ42 CJ42 merged commit b797c5b into main Nov 20, 2024
2 checks passed
@CJ42 CJ42 deleted the docs/mobile-fix branch November 20, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeneaVranceanu JeneaVranceanu JeneaVranceanu approved these changes

@CJ42 CJ42 CJ42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mustafademiray @CJ42 @JeneaVranceanu