Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganise Quickstart section with new branding + move LUKSO wallet up on Network pages #1162

Merged
merged 12 commits into from
Nov 11, 2024
Merged

Reorganise Quickstart section with new branding + move LUKSO wallet up on Network pages #1162

merged 12 commits into from
Nov 11, 2024

Conversation

CJ42
Copy link
Member

@CJ42 CJ42 commented Nov 1, 2024 •
edited
Loading

Screenshot 2024-11-01 at 08 12 06 Screenshot 2024-11-01 at 08 12 27 Screenshot 2024-11-01 at 08 12 17

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

Deployed with Cloudflare Pages ☁️ 🚀 🆗

@CJ42 CJ42 force-pushed the chore/lukso-description-adjusted branch from 2cae807 to f8bf2c3 Compare November 1, 2024 16:40
@CJ42 CJ42 marked this pull request as draft November 1, 2024 16:42
@CJ42
Copy link
Member Author

CJ42 commented Nov 1, 2024 •
edited
Loading

Converting to draft for now

Remaining tasks

  • Remove new images or replace with new branded assets
  • Rename pages according to new titles + setup redirects
  • Remove duplicate content for Benefits of LSPs + merge both content
  • Remove setup instructions related to LUKSO Playground + move them in the playground repository

JeneaVranceanu
JeneaVranceanu approved these changes Nov 4, 2024
View reviewed changes
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
@CJ42 CJ42 marked this pull request as ready for review November 11, 2024 10:51
@CJ42 CJ42 requested a review from YamenMerhi as a code owner November 11, 2024 10:51
JeneaVranceanu
JeneaVranceanu requested changes Nov 11, 2024
View reviewed changes
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
docs/learn/benefits-lukso-standards.md Outdated Show resolved Hide resolved
@mustafademiray
Copy link
Collaborator

some of the images in the boxes are not loading
image

@CJ42
Copy link
Member Author

CJ42 commented Nov 11, 2024

some of the images in the boxes are not loading image

@mustafademiray It is intended, as we do not have branded pictures for these. Suggest we add them later :)

@CJ42 CJ42 force-pushed the chore/lukso-description-adjusted branch from b362746 to 8cf2280 Compare November 11, 2024 18:05
@CJ42 CJ42 merged commit f2f9d0b into main Nov 11, 2024
2 checks passed
@CJ42 CJ42 deleted the chore/lukso-description-adjusted branch November 11, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeneaVranceanu JeneaVranceanu JeneaVranceanu requested changes

@richtera richtera richtera approved these changes

@YamenMerhi YamenMerhi Awaiting requested review from YamenMerhi YamenMerhi is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CJ42 @mustafademiray @richtera @JeneaVranceanu