Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organise sidebar of contracts section + improve LSP25 standard page + improve type of executions in LSP6 standard page + improve the Contracts section for LSP6 #1152

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

CJ42
Copy link
Member

@CJ42 CJ42 commented Oct 8, 2024

Contracts section sidebar

before

image

after

image

LSP6 section for Types of Interactions

image

LSP25 page improved

Moved the two sections below out of the LSP6 standard page and inside the LSP25 standard page:

image

@CJ42 CJ42 marked this pull request as ready for review October 8, 2024 16:47
@CJ42 CJ42 changed the title Re-organise sidebar of contracts section + improve LSP25 standard page + improve type of executions in LSP6 standard page Re-organise sidebar of contracts section + improve LSP25 standard page + improve type of executions in LSP6 standard page + improve the Contracts section for LSP6 Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Deployed with Cloudflare Pages ☁️ 🚀 🆗

Copy link
Member

@JeneaVranceanu JeneaVranceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo 🙂

docs/standards/access-control/lsp6-key-manager.md Outdated Show resolved Hide resolved
@mustafademiray
Copy link
Collaborator

for the "Deployed Base Contracts" title, it always confuses me for a second if its something about Base(coinbase) chain. do we have an alternative for that? I am not sure how accurate but maybe something like: Deployed Main Contracts

@CJ42
Copy link
Member Author

CJ42 commented Oct 9, 2024

a second if its something about Base(coinbase)

Let's call it Deployed Implementation Contracts

@CJ42 CJ42 merged commit 24bec59 into main Oct 9, 2024
2 checks passed
@CJ42 CJ42 deleted the contracts-docs branch October 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants