Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "documentAccess": "dynamic-page" to manifest.json #321

Closed
wants to merge 5 commits into from

Conversation

0m4r
Copy link
Collaborator

@0m4r 0m4r commented Dec 29, 2024

Updates the manifest.json with "documentAccess": "dynamic-page".
lighting is updated too.

resolves: #317

@0m4r 0m4r self-assigned this Dec 29, 2024
@coveralls
Copy link

coveralls commented Dec 29, 2024

Pull Request Test Coverage Report for Build 12572029779

Details

  • 27 of 37 (72.97%) changed or added relevant lines in 20 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.644%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utilities/prepareExport.ts 0 1 0.0%
src/index.ts 0 9 0.0%
Totals Coverage Status
Change from base Build 11893275335: 0.0%
Covered Lines: 584
Relevant Lines: 812

💛 - Coveralls

@0m4r
Copy link
Collaborator Author

0m4r commented Dec 29, 2024

@lukasoppermann this is still in progress, but I would like to have an early review if possible.
There are quite some changes, package updates, and so on... I still have not tested this extensively yet...

@lukasoppermann I guess it is done now!
(I will need to check the test coverage, tho: Coverage decreased (-0.003%) to 70.641% 👯 )

Copilot did quite help to extend the code coverage 😏

@0m4r 0m4r marked this pull request as ready for review December 29, 2024 19:06
@0m4r 0m4r marked this pull request as draft December 29, 2024 19:07
@0m4r 0m4r marked this pull request as ready for review December 29, 2024 21:43
@0m4r 0m4r requested a review from lukasoppermann December 30, 2024 14:12
@lukasoppermann
Copy link
Owner

Hey, I know it is annoying, but could you cherrypick & move all the formatting changes to a new PR (we can merge it first and than rebase this one)?

The idea:

  • 1 PR with your formatting changes that has NO change to behavior at all.
  • 1 PR for the changes needed for documentAccess which has NO additional formatting changes / unneeded dependency updates

With the small amount of test coverage we have due to much of it happening in Figma, it just makes it really hard to review changes otherwise.

Thank you and a good start into the new year. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "documentAccess": "dynamic-page" to manifest.json
3 participants