Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stream api instead of while loop to read tail of file #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use stream api instead of while loop to read tail of file #14

wants to merge 2 commits into from

Conversation

lukashinsch
Copy link
Owner

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 96.61% when pulling a07dd87 on refactor-to-streams into d693556 on master.

@lukashinsch lukashinsch force-pushed the refactor-to-streams branch 2 times, most recently from 84ad2ea to f419d5e Compare March 29, 2015 14:57
@coveralls
Copy link

Coverage Status

Coverage decreased (-68.83%) to 28.89% when pulling f419d5ec75cef7eed6f9e298db4f6959ef100c64 on refactor-to-streams into d693556 on master.

@lukashinsch lukashinsch force-pushed the refactor-to-streams branch from f419d5e to 66b5f50 Compare March 29, 2015 15:10
@coveralls
Copy link

Coverage Status

Coverage decreased (-68.83%) to 28.89% when pulling 66b5f50dbcaf4c10af3a542464819903e9c67640 on refactor-to-streams into d693556 on master.

@lukashinsch lukashinsch force-pushed the refactor-to-streams branch from 66b5f50 to b79f2a5 Compare March 29, 2015 15:27
@coveralls
Copy link

Coverage Status

Coverage decreased (-79.86%) to 17.86% when pulling b79f2a52a7d2f660690a9cbb19ad539c1ec06da9 on refactor-to-streams into d693556 on master.

@lukashinsch lukashinsch force-pushed the refactor-to-streams branch from b79f2a5 to 5ef16f5 Compare March 29, 2015 15:32
@coveralls
Copy link

Coverage Status

Coverage decreased (-79.86%) to 17.86% when pulling 5ef16f5 on refactor-to-streams into d693556 on master.

@jgoldhammer
Copy link

Hi, what about this PR? Would like to see it in your master and in next release...

@jgoldhammer
Copy link

@lukashinsch Hi, what about this PR? Would like to see it in your master and in next release...

@lukashinsch
Copy link
Owner Author

I need to check why I stopped working on this, probably needs some more work. I'll look into it as soon as I get a chance.

@lukashinsch
Copy link
Owner Author

Since this is an internal refactoring I released 0.2.9 without the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukashinsch @coveralls @jgoldhammer