Fix display of items with uppercase chars in list

lukasbestle · Jul 26, 2019 · 8938e58 · 8938e58
1 parent c41b609
commit 8938e58
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/src/Shareable/ItemCollection.php b/src/Shareable/ItemCollection.php
@@ -43,6 +43,6 @@ public function __construct(App $app, string $path)
         // sort by item name
         ksort($data);
 
-        parent::__construct($data);
+        $this->data = $data;
     }
 }
diff --git a/tests/Shareable/ItemCollectionTest.php b/tests/Shareable/ItemCollectionTest.php
@@ -13,8 +13,9 @@ class ItemCollectionTest extends TestCase
     public function testConstruct()
     {
         $collection = new ItemCollection($this->app, $this->itemsPath);
-        $this->assertEquals(9, $collection->count());
+        $this->assertEquals(10, $collection->count());
         $this->assertEquals([
+            'UpPeRcAsE',
             'expired',
             'expired-with-dir',
             'no-activity',
@@ -26,5 +27,6 @@ public function testConstruct()
             'valid-with-dir'
         ], $collection->keys());
         $this->assertInstanceOf(Item::class, $collection->get('valid'));
+        $this->assertInstanceOf(Item::class, $collection->get('UpPeRcAsE'));
     }
 }
diff --git a/tests/Shareable/ItemsTest.php b/tests/Shareable/ItemsTest.php
@@ -78,6 +78,7 @@ public function testCleanUp()
         $this->assertFileExists($this->itemsPath . '/not-started.json');
         $this->assertFileExists($this->itemsPath . '/only-expiry.json');
         $this->assertFileExists($this->itemsPath . '/only-timeout.json');
+        $this->assertFileExists($this->itemsPath . '/UpPeRcAsE.json');
         $this->assertFileExists($this->itemsPath . '/valid.json');
         $this->assertFileExists($this->itemsPath . '/valid-with-dir.json');
         $this->assertFileExists($this->filesPath . '/.i-am-invisible');
@@ -110,6 +111,7 @@ public function testCleanUp()
         $this->assertFileExists($this->itemsPath . '/not-started.json');
         $this->assertFileNotExists($this->itemsPath . '/only-expiry.json');
         $this->assertFileNotExists($this->itemsPath . '/only-timeout.json');
+        $this->assertFileExists($this->itemsPath . '/UpPeRcAsE.json');
         $this->assertFileExists($this->itemsPath . '/valid.json');
         $this->assertFileExists($this->itemsPath . '/valid-with-dir.json');
         $this->assertFileExists($this->filesPath . '/.i-am-invisible');

diff --git a/tests/fixtures/items/UpPeRcAsE.json b/tests/fixtures/items/UpPeRcAsE.json
@@ -0,0 +1,9 @@
+{
+  "activity": 9999999999,
+  "created": 1234567890,
+  "downloads": 543,
+  "expires": 9999999999,
+  "filename": "valid.txt",
+  "timeout": 2678400,
+  "user": "admin"
+}