Merge pull request #7 from luizppa/skelleton-loading

Remove loading conditional render
luizppa · Nov 4, 2021 · e6d8d2c · e6d8d2c
2 parents d3994b9 + 38e4c08
commit e6d8d2c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/projects/ng-github-contributions/src/lib/components/github-board/github-board.component.html b/projects/ng-github-contributions/src/lib/components/github-board/github-board.component.html
@@ -1,5 +1,5 @@
-<div class="board-container" [style.minHeight]="minHeight">
-    <div class="columns" *ngIf="!loading">
+<div class="board-container">
+    <div class="columns">
         <div class="labels-column" *ngIf="showLabels">
             <span [style.fontSize]="labelSize" class="day-label" [style.height]="labelContainerHeight">Fri</span>
             <span [style.fontSize]="labelSize" class="day-label" [style.height]="labelContainerHeight">Wed</span>

diff --git a/projects/ng-github-contributions/src/lib/components/github-board/github-board.component.ts b/projects/ng-github-contributions/src/lib/components/github-board/github-board.component.ts
@@ -33,6 +33,7 @@ export class GithubBoardComponent implements OnInit, OnChanges {
   }
 
   private loadData(): void {
+    this.loadContributions({});
     if (!!this.profile){
       this.githubService.loadData(this.profile).then(
         (contributions) => {
@@ -93,12 +94,4 @@ export class GithubBoardComponent implements OnInit, OnChanges {
     return this.options.showLegend ?? true;
   }
 
-  public get minHeight(): string {
-    const cellSize = this.options.cellSize ?? DEFAULT_CELL_SIZE;
-    const labelSize = this.options.labels?.size ?? DEFAULT_LABEL_SIZE;
-    const legendSize = 8 + Math.max(12, cellSize);
-
-    return `${((cellSize + 6) * 7) + labelSize + legendSize}px`;
-  }
-
 }