fix: defer close after error check

luissimas · Jun 24, 2024 · 3fc236b · 3fc236b
1 parent aa5817e
commit 3fc236b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/collector/collector.go b/internal/collector/collector.go
@@ -72,17 +72,17 @@ func (c *Collector) collectMetrics(root fs.FS) (metrics.Metrics, error) {
 		}
 
 		f, err := root.Open(path)
-		defer f.Close()
 		if err != nil {
 			slog.Error("Error opening file", slog.Any("error", err), slog.String("path", path))
 			return nil
 		}
+		defer f.Close()
 		_, err = buf.ReadFrom(f)
-		defer buf.Reset()
 		if err != nil {
 			slog.Error("Error reading file into buffer", slog.Any("error", err), slog.String("path", path))
 			return nil
 		}
+		defer buf.Reset()
 		metrics := CollectNoteMetrics(buf.Bytes())
 		notes[path] = metrics
 		linkCount += metrics.LinkCount