Fix iconsax font #10
Open
Fix iconsax font #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot the individual files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for the icons. I noticed that all two colored icons dont work (because they are split into multiple glyphs). Additionally, some icons are rendered with an offset, so that they are not centered anymore. Both issues are demonstrated in the screenshots below:
| 
| 
|
|
|
This pull request is supposed to just fix the offsetting. As the other icons families (bulk and twotone) were unusable anyway, i left them out. Additionally, if im not mistaken, the "outline" family is equal to the "linear" family, so I did not recreate this one either.
To have a more verbose and thus better access to the different icon families, they have to be accessed by calling
IconsaxLinear,IconsaxBrokenandIconsaxBroken.I also noticed that some of the icon names didnt match the others in the other families (e.g. each family hat ~6 icons that had names like "group" or "frame" which in reality had to be named differently) probably because of a poor figma export. So I re-arranged all the svg icons to match in the three families. If you want, I can send them over if you need them.
With that, at least the flutter library of Iconsax should be a bit more stable. Dont hesitate in case you have questions :)