Update ConnectionProvider to support AWS writer failovers #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
requested changes
Sep 3, 2024
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
aegbert5
force-pushed
the
update-connection-provider-to-support-aws-writer-failovers
branch
4 times, most recently
from
4aea4e8 to
81e2fb2
Compare
tmccombs
reviewed
Sep 6, 2024
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
tmccombs
requested changes
Sep 6, 2024
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
| testConn = connectionPool.getConnection() | ||
| } catch { | ||
| case _: SQLTransientConnectionException => { TimeUnit.MILLISECONDS.sleep(100) } // do nothing | ||
| case e: Exception => throw e |
There was a problem hiding this comment.
This is unnecessary. If you don't catch an excetpion in a catch block it will automatically get rethrown
hunterrees
requested changes
Sep 10, 2024
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
hunterrees
requested changes
Sep 12, 2024
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
hunterrees
reviewed
Sep 13, 2024
hunterrees
approved these changes
Sep 13, 2024
tmccombs
reviewed
Sep 17, 2024
tmccombs
reviewed
Sep 17, 2024
worker/src/main/scala/com/lucidchart/piezo/ConnectionProvider.scala
Outdated
Show resolved
Hide resolved
tmccombs
approved these changes
Sep 17, 2024
tmccombs
requested changes
Sep 17, 2024
aegbert5
force-pushed
the
update-connection-provider-to-support-aws-writer-failovers
branch
from
725a4d9 to
4ec9ad4
Compare
tmccombs
reviewed
Sep 18, 2024
| size > 1 | ||
| } | ||
| }) | ||
| // TODO: override "removeEldestEntry" |
There was a problem hiding this comment.
you can revome this now right?
tmccombs
reviewed
Sep 18, 2024
| private val cachedIpWithExpiration: java.util.Map[String, CachedIpWithExpiration] = Collections.synchronizedMap(new LinkedHashMap[String, CachedIpWithExpiration]() { | ||
| // There is only 1 element to be stored in this list at a time, so we remove the oldest entries once we reach 2+ entries | ||
| override def removeEldestEntry(eldest: java.util.Map.Entry[String, CachedIpWithExpiration]): Boolean = { | ||
| size > 1 |
There was a problem hiding this comment.
wait.... if we only have 1 entry, maybe it would be simpler just to have a variable for this (synchronized, or maybe @volatile?)
There was a problem hiding this comment.
Yeah probably simpler to do make is a single optional object. I think @volatile should be adequate over using synchronized since as long as there is a cached entry to use, we shouldn't care about whether another thread tried to enter the new or old DNS result into the cache.
There was a problem hiding this comment.
On second thought, perhaps synchronized may be better here. It just makes the cache more reliable if there isn't a race-condition between which IP value is set for the DNS cache
tmccombs
approved these changes
Sep 18, 2024
aegbert5
force-pushed
the
update-connection-provider-to-support-aws-writer-failovers
branch
from
4ec9ad4 to
89bb6a6
Compare
tmccombs
approved these changes
Sep 19, 2024
aegbert5
force-pushed
the
update-connection-provider-to-support-aws-writer-failovers
branch
from
89bb6a6 to
10e041e
Compare
aegbert5
force-pushed
the
update-connection-provider-to-support-aws-writer-failovers
branch
from
10e041e to
c571102
Compare
tmccombs
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.