feat(docs): Make input autofocus in the /icons page #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danilo-leal Thanks for the PR. Awesome that you use Lucide at Zed! |
|
Absolutely! I'm constantly refreshing https://lucide.dev/icons/, so having the input automatically focused would be convenient so I don't have to reach for the mouse, but definitely feel free to ditch if you think it doesn't make sense 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
This PR simply adds the
autofocusattribute to theInputcomponent on the/iconspage. This allows users to immediately type their search query, which then avoids an extra click. Here's a quick video with the before & after:autofocus-input.mp4
Love Lucide—we use it extensively at Zed! 😃 I basically have the docs tab open every day.
Before Submitting