CFHTTP using TLS v1.3 (allows TLS 1.2 fallback) LDEV-3239 (#1281)

* CFHTTP using TLS v1.3 (allows TLS 1.2 fallback) * add report of cfhttp TLS version to tests this is an external dependency, probably will disable by default * add note test that cfhttp TLS version is jvm dependent
lucee · Apr 14, 2021 · fb0a129 · fb0a129
1 parent 9b99fbc
commit fb0a129
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/core/src/main/java/lucee/runtime/tag/Http.java b/core/src/main/java/lucee/runtime/tag/Http.java
@@ -1431,7 +1431,7 @@ private void ssl(HttpClientBuilder builder) throws PageException {
 		final SSLConnectionSocketFactory sslsf;
 		try {
 			// SSLContext sslcontext = SSLContexts.createSystemDefault();
-			SSLContext sslcontext = SSLContext.getInstance("TLSv1.2");
+			SSLContext sslcontext = SSLContext.getInstance("TLS");
 			if (!StringUtil.isEmpty(this.clientCert)) {
 				if (this.clientCertPassword == null) this.clientCertPassword = "";
 				File ksFile = new File(this.clientCert);

diff --git a/test/tags/Http.cfc b/test/tags/Http.cfc
@@ -56,6 +56,11 @@ component extends="org.lucee.cfml.test.LuceeTestCase" {
 		assertEquals(data,res.httpRequestData.content);
 	}
 
-
-
+	public void function testCheckTLSVersion(){
+		http url="https://www.howsmyssl.com/a/check" result="local.res";
+		expect(isJson(res.filecontent)).toBeTrue();
+		var tlsReport = DeserializeJson(res.filecontent);
+		SystemOutput("", true);
+		SystemOutput("CFHTTP is using [#tlsReport.tls_version#] (jvm default)", true);
+	}
 }