Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package.json exports #258

Merged
merged 2 commits into from
May 7, 2024
Merged

Fix package.json exports #258

merged 2 commits into from
May 7, 2024

Conversation

lucaong
Copy link
Owner

@lucaong lucaong commented Apr 3, 2024

Resolves: #255

@lucaong lucaong mentioned this pull request Apr 3, 2024
Closed
ItamarGronich
ItamarGronich approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@ItamarGronich ItamarGronich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!
This seems to be resolve this issue in the reproduction repo.

I still get errors in my actual code but i'll get to the bottom of that.
probably something bad with my tsconfig.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@lucaong lucaong merged commit ef74099 into master May 7, 2024
2 checks passed
@lucaong lucaong deleted the fix-package-json-exports branch May 7, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItamarGronich ItamarGronich ItamarGronich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript with module resolution "NodeNext" + type: "commonjs" fails to import the commonJS module
2 participants
@lucaong @ItamarGronich