Better typing of combination operators #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaong
force-pushed
the
better-typing-of-combinator-operators
branch
3 times, most recently
from
09bf223 to
b5495cb
Compare
…rator Restrict the type of the `combineWith` option to only allowed string values (currently `'or'`, `'and'`, `'and_not'`, the same uppercased or capitalized, or `undefined`). Raise a more informative error when an invalid operator is specified.
lucaong
force-pushed
the
better-typing-of-combinator-operators
branch
from
b5495cb to
24f553b
Compare
lucaong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict the type of the
combineWithsearch option to only allowed values (currently'or','and','and_not', the same strings uppercased or capitalized, orundefined).Raise a more informative error if an invalid operator is specified.