DM-42586: Handle empty ORCiD values in technote.toml #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if an author didn't have an orcid in the authordb.yaml file (or didn't provide one when working manually with templatekit), the empty string would be added as the value for the orcid in technote.toml. This breaks technote builds because the Pydantic model won't validate an empty string as an orcid.
In jinja syntax we can omit the orcid line without creating whitespace issues by putting an if clause on the same line and using the "-" operator to consume the empty line.
Also fix the "tuple" in address example value. There shouldn't be an extra set of parentheses on the example address values.