Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42586: Handle empty ORCiD values in technote.toml #236

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

jonathansick
Copy link
Member

Previously if an author didn't have an orcid in the authordb.yaml file (or didn't provide one when working manually with templatekit), the empty string would be added as the value for the orcid in technote.toml. This breaks technote builds because the Pydantic model won't validate an empty string as an orcid.

In jinja syntax we can omit the orcid line without creating whitespace issues by putting an if clause on the same line and using the "-" operator to consume the empty line.

Also fix the "tuple" in address example value. There shouldn't be an extra set of parentheses on the example address values.

Previously if an author didn't have an orcid in the authordb.yaml file
(or didn't provide one when working manually with templatekit), the
empty string would be added as the value for the orcid in technote.toml.
This breaks technote builds because the Pydantic model won't validate an
empty string as an orcid.

In jinja syntax we can omit the orcid line without creating whitespace
issues by putting an if clause on the same line and using the "-"
operator to consume the empty line.

Also fix the "tuple" in address example value. There shouldn't be an
extra set of parentheses on the example address values.
- Update to setup-python@v5
- Migrate test matrix to test Python 3.11 and 3.12; drop 3.8 and 3.9.
@jonathansick jonathansick merged commit 089b686 into main Jan 22, 2024
7 checks passed
@jonathansick jonathansick deleted the ticket/DM-42586 branch January 22, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant