tickets/PREOPS-4603: prepare schedview's scheduler_dashboard app for running at USDF w/ k8 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 12.26% 12.24% -0.02%
==========================================
Files 39 39
Lines 3238 3241 +3
Branches 492 492
==========================================
Hits 397 397
- Misses 2832 2835 +3
Partials 9 9 ☔ View full report in Codecov by Sentry. |
alserene
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The k8 ingress seems to have trouble getting supplying bokeh js libraries unless the dashboard is served a couple of directories "down" in the url, that is https://myhost/a/b works, but https://myhost and https://myhost/a do not.
There might be a way either to get bokeh to serve its libraries differently or get the ingress to handle routing to the js libraries, but I couldn't find it, and just moving the URL is easy and has no downsides that I can see.
I named the dir "scheduler-snapshot" here to make it clear how it is different from other existing planned or existing schedview dashboards, which can also be thought of as scheduler-related dashboards. What makes this dashboard distinctive is that it looks at the state of the scheduler as captured (in a pickle, at least for now) at a given time.