Apply review suggestions

Co-authored-by: Jim Bosch <[email protected]>
lsst · Oct 17, 2023 · 2a1b9c1 · 2a1b9c1
1 parent d147228
commit 2a1b9c1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/python/lsst/daf/butler/datastore/_datastore.py b/python/lsst/daf/butler/datastore/_datastore.py
@@ -554,7 +554,7 @@ def put(self, inMemoryDataset: Any, datasetRef: DatasetRef) -> None:
         raise NotImplementedError("Must be implemented by subclass")
 
     @abstractmethod
-    def put_new(self, inMemoryDataset: Any, datasetRef: DatasetRef) -> Mapping[str, DatasetRef]:
+    def put_new(self, in_memory_dataset: Any, dataset_ref: DatasetRef) -> Mapping[str, DatasetRef]:
         """Write a `InMemoryDataset` with a given `DatasetRef` to the store.
 
         Parameters

diff --git a/python/lsst/daf/butler/datastore/stored_file_info.py b/python/lsst/daf/butler/datastore/stored_file_info.py
@@ -297,9 +297,6 @@ def from_record(cls: type[StoredFileInfo], record: Mapping[str, Any]) -> StoredF
         # Convert name of StorageClass to instance
         storageClass = cls.storageClassFactory.getStorageClass(record["storage_class"])
         component = record["component"] if (record["component"] and record["component"] != NULLSTR) else None
-
-        # UUID may be converted to string, e.g. in round-trip through JSON,
-        # convert it back to UUID.
         info = cls(
             formatter=record["formatter"],
             path=record["path"],

diff --git a/python/lsst/daf/butler/registries/sql.py b/python/lsst/daf/butler/registries/sql.py
@@ -223,6 +223,7 @@ def __init__(self, database: Database, defaults: RegistryDefaults, managers: Reg
 
         # TODO: This is currently initialized by `make_datastore_tables`,
         # eventually we'll need to do it during construction.
+        # The mapping is indexed by the opaque table name.
         self._datastore_record_classes: Mapping[str, type[StoredDatastoreItemInfo]] = {}
 
     def __str__(self) -> str: