-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-43077: Convert all tasks to use CalibrateImageTask outputs #236
base: main
Are you sure you want to change the base?
Conversation
@@ -35,7 +35,6 @@ tasks: | |||
class: lsst.pipe.tasks.postprocess.ConsolidateVisitSummaryTask | |||
config: | |||
connections.calexpType: parameters.fakesType | |||
connections.calexp: "{calexpType}initial_pvi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this one won't work, because the default is initial_pvi
without referencing calexpType
. Can you confirm that the fakes pipeline has the correct structure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. calibrateImage
isn't setup to work with the fakes pipeline as it is used in AP, I don't think. This may require some discussion: I put it on the schedule for Monday's meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, maybe it's fine: ci_ap passed on Jenkins, and that runs the fakes pipeline for DC2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for the record, this question cross-references lsst/pipe_tasks#979.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9a58e21
to
d75cc0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR changes the pipeline structure by replacing a fakes input with a non-fakes input.
@@ -35,7 +35,6 @@ tasks: | |||
class: lsst.pipe.tasks.postprocess.ConsolidateVisitSummaryTask | |||
config: | |||
connections.calexpType: parameters.fakesType | |||
connections.calexp: "{calexpType}initial_pvi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove now unused datasets.
d75cc0b
to
2dc7f48
Compare
Remove now unused datasets.
{Summary of changes. Prefix PR title with JIRA issue.}
scons
and/orstack-os-matrix
)?ap_verify.py
on at least one of the standard datasets?For changes to metrics, the
print_metricvalues
script fromlsst.verify
will be useful.