DM-45677: Remove MockApPipe.yaml and tests that need it #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-45677
branch
from
3d2a555 to
1b63db2
Compare
BrunoSanchez
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Is this because the files that were removed?
There was a problem hiding this comment.
As stated in the commit message, no. This is an incidental problem I noticed while vetting ap_verify.table.
There was a problem hiding this comment.
See https://github.com/lsst/templates/tree/main/project_templates/stack_package/example_pythononly for what a Python-only package is supposed to look like.
MockApPipe.yaml let us run black-box tests of pipeline execution, but the pipeline was more prone to breakdowns than the pipeline driver itself. Replace MockApPipe.yaml with a traditional mock, even though it depends on implementation details of pipeline_driver.
ap_verify has always been a Python-only package, but when we first created it we cargo-culted some C++ support infrastructure. Removing these files will prevent future confusion.
kfindeisen
force-pushed
the
tickets/DM-45677
branch
from
1b63db2 to
b1cb93b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes MockApPipe.yaml from our unit test system, replacing its use with more conventional (white-box) mocks.
sconsand/orstack-os-matrix)?ap_verify.pyon at least one of the standard datasets?For changes to metrics, the
print_metricvaluesscript fromlsst.verifywill be useful.