DM-43416: Migrate AP code to external APDB configs #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApdbMetricTasks should have their APDB configured in a way that's consistent with diaPipe, or they will break (possibly only at runtime).
None of the tests actually try to load an APDB, so there's no need to define apdb_config_url for those components.
This field specifies where to store the config created by ap_verify.
kfindeisen
force-pushed
the
tickets/DM-43416
branch
from
fee4ee0 to
fea709f
Compare
isullivan
approved these changes
Apr 29, 2024
This change removes ap_verify's dependency on the deprecated makeApdb function. Although the new configs allow better support for Cassandra APDBs, ap_verify itself only supports SQL (particularly SQLite), given its restricted scope.
kfindeisen
force-pushed
the
tickets/DM-43416
branch
from
fea709f to
124dfae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
ap_verifyframework and the metrics pipelines to use new-style configs instead of handlingApdbConfigobjects directly. It must be merged after lsst/ap_association#210 and lsst/verify#124.sconsand/orstack-os-matrix)?ap_verify.pyon at least one of the standard datasets?For changes to metrics, the
print_metricvaluesscript fromlsst.verifywill be useful.