DM-41063: Remove trailedSourceFilter and add to filterDiaSourceCatalog #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmartradio
force-pushed
the
tickets/DM-41063
branch
from
15c9904 to
aae5785
Compare
mrawls
approved these changes
May 2, 2024
| @@ -455,8 +455,10 @@ def run(self, diaSourceCat): | |||
| results : `lsst.pipe.base.Struct` | |||
| Results struct with components. | |||
| """ | |||
| # TODO Add docstrings for diffIm | |||
There was a problem hiding this comment.
Added docstrings and updated the results docstrings to be more comprehensive.
bsmartradio
force-pushed
the
tickets/DM-41063
branch
from
c543d8d to
55aefd6
Compare
Update docs and unit tests to include trailed source filtering in filterDiaSourceCatalog.py
bsmartradio
force-pushed
the
tickets/DM-41063
branch
from
55aefd6 to
2e02abf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove longTrailedSources from
diaPipe, change its output toArrowAstropy, and add longTrailedSources to output fromfilteredDiaSourceCatalogsconsand/orstack-os-matrix)?ap_verify.pyon at least one of the standard datasets?For changes to metrics, the
print_metricvaluesscript fromlsst.verifywill be useful.