Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-41024: Add longTrailedSources to testPipeline unit tests #205

Merged
merged 1 commit into from
Nov 16, 2023
Merged

DM-41024: Add longTrailedSources to testPipeline unit tests #205

merged 1 commit into from
Nov 16, 2023

Conversation

bsmartradio
Copy link
Contributor

longTrailedSources needs to be added to the unit test output otherwise ap_verify fails to scons.

mrawls
mrawls approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are fine, but I'm surprised everything has been fine with a typo in assocDiaSrc prior to now, in the test. If it's not too much trouble to fix that and verify (ha) it doesn't break anything, that would be appreciated.

tests/test_testPipeline.py Show resolved Hide resolved
@bsmartradio bsmartradio merged commit ee528e9 into main Nov 16, 2023
2 checks passed
@bsmartradio bsmartradio deleted the tickets/DM-41024 branch November 16, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrawls mrawls mrawls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsmartradio @mrawls