Replace legacy metrics for ApVerifyWithFakes

Replace metrics in MetricsForFakes.yaml for analysis_tools based
metrics of completeness.
New metrics come inherently inside ap_pipe ApPipeWithFakes.yaml.
Delete the MetricsForFakes.yaml file and modify contracts in all
pipeline yaml files to reflect this change.

pipelines/DECam/ApVerifyWithFakes.yaml

@@ -20,19 +20,3 @@ tasks:
     config:
       doPackageAlerts: True
       alertPackager.doWriteAlerts: True
-contracts:
-  # Contracts removed by excluding apPipe
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag20t22.connections.ConnectionsClass(config=apFakesCompletenessMag20t22).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag22t24.connections.ConnectionsClass(config=apFakesCompletenessMag22t24).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag24t26.connections.ConnectionsClass(config=apFakesCompletenessMag24t26).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag20t22.connections.ConnectionsClass(config=apFakesCountMag20t22).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag22t24.connections.ConnectionsClass(config=apFakesCountMag22t24).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag24t26.connections.ConnectionsClass(config=apFakesCountMag24t26).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCount.connections.ConnectionsClass(config=apFakesCount).matchedFakes.name

pipelines/HSC/ApVerifyWithFakes.yaml

@@ -17,19 +17,3 @@ tasks:
     config:
       doPackageAlerts: True
       alertPackager.doWriteAlerts: True
-contracts:
-  # Contracts removed by excluding apPipe
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag20t22.connections.ConnectionsClass(config=apFakesCompletenessMag20t22).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag22t24.connections.ConnectionsClass(config=apFakesCompletenessMag22t24).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag24t26.connections.ConnectionsClass(config=apFakesCompletenessMag24t26).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag20t22.connections.ConnectionsClass(config=apFakesCountMag20t22).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag22t24.connections.ConnectionsClass(config=apFakesCountMag22t24).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag24t26.connections.ConnectionsClass(config=apFakesCountMag24t26).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCount.connections.ConnectionsClass(config=apFakesCount).matchedFakes.name

pipelines/LSSTCam-imSim/ApVerifyWithFakes.yaml

@@ -17,19 +17,3 @@ tasks:
     config:
       doPackageAlerts: True
       alertPackager.doWriteAlerts: True
-contracts:
-  # Contracts removed by excluding apPipe
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag20t22.connections.ConnectionsClass(config=apFakesCompletenessMag20t22).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag22t24.connections.ConnectionsClass(config=apFakesCompletenessMag22t24).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag24t26.connections.ConnectionsClass(config=apFakesCompletenessMag24t26).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag20t22.connections.ConnectionsClass(config=apFakesCountMag20t22).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag22t24.connections.ConnectionsClass(config=apFakesCountMag22t24).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag24t26.connections.ConnectionsClass(config=apFakesCountMag24t26).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCount.connections.ConnectionsClass(config=apFakesCount).matchedFakes.name

pipelines/_ingredients/ApVerifyWithFakes.yaml

@@ -5,7 +5,6 @@ description: Fully instrumented AP pipeline with fakes
 imports:
   - location: $AP_PIPE_DIR/pipelines/_ingredients/ApPipeWithFakes.yaml
   # Most metrics should not be run with fakes, to avoid bias or contamination.
-  - location: $AP_VERIFY_DIR/pipelines/_ingredients/MetricsForFakes.yaml
   - location: $AP_VERIFY_DIR/pipelines/_ingredients/ConversionsForFakes.yaml
 tasks:
   diaPipe:
@@ -15,20 +14,3 @@ tasks:
       # we have an alternative.
       doPackageAlerts: True
       alertPackager.doWriteAlerts: True
-contracts:
-  # Metric inputs must match pipeline outputs
-  # Use of ConnectionsClass for templated fields is a workaround for DM-30210
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag20t22.connections.ConnectionsClass(config=apFakesCompletenessMag20t22).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag22t24.connections.ConnectionsClass(config=apFakesCompletenessMag22t24).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCompletenessMag24t26.connections.ConnectionsClass(config=apFakesCompletenessMag24t26).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag20t22.connections.ConnectionsClass(config=apFakesCountMag20t22).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag22t24.connections.ConnectionsClass(config=apFakesCountMag22t24).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCountMag24t26.connections.ConnectionsClass(config=apFakesCountMag24t26).matchedFakes.name
-  - injectedMatch.connections.ConnectionsClass(config=injectedMatch).matchedDiaSources.name ==
-      apFakesCount.connections.ConnectionsClass(config=apFakesCount).matchedFakes.name